refactor: Replace console.error with structured logging and feedback (#12175)

This commit is contained in:
Gal Zahavi
2025-10-29 13:20:11 -07:00
committed by GitHub
parent 66e981ed1e
commit b31b786db7
3 changed files with 10 additions and 10 deletions

View File

@@ -617,10 +617,10 @@ export function loadSettings(
'utf-8',
);
} catch (e) {
console.error(
`Error migrating settings file on disk: ${getErrorMessage(
e,
)}`,
coreEvents.emitFeedback(
'error',
'Failed to migrate settings file.',
e,
);
}
} else {

View File

@@ -6,7 +6,7 @@
import * as fs from 'node:fs/promises';
import * as path from 'node:path';
import { spawnAsync } from '@google/gemini-cli-core';
import { debugLogger, spawnAsync } from '@google/gemini-cli-core';
/**
* Checks if the system clipboard contains an image (macOS only for now)
@@ -105,7 +105,7 @@ export async function saveClipboardImage(
// No format worked
return null;
} catch (error) {
console.error('Error saving clipboard image:', error);
debugLogger.warn('Error saving clipboard image:', error);
return null;
}
}

View File

@@ -9,7 +9,7 @@ import path from 'node:path';
import os, { EOL } from 'node:os';
import crypto from 'node:crypto';
import type { Config } from '../config/config.js';
import type { AnyToolInvocation } from '../index.js';
import { debugLogger, type AnyToolInvocation } from '../index.js';
import { ToolErrorType } from './tool-error.js';
import type {
ToolInvocation,
@@ -226,7 +226,7 @@ export class ShellToolInvocation extends BaseToolInvocation<
.filter(Boolean);
for (const line of pgrepLines) {
if (!/^\d+$/.test(line)) {
console.error(`pgrep: ${line}`);
debugLogger.error(`pgrep: ${line}`);
}
const pid = Number(line);
if (pid !== result.pid) {
@@ -235,7 +235,7 @@ export class ShellToolInvocation extends BaseToolInvocation<
}
} else {
if (!signal.aborted) {
console.error('missing pgrep output');
debugLogger.error('missing pgrep output');
}
}
}
@@ -424,7 +424,7 @@ export class ShellTool extends BaseDeclarativeTool<
const commandCheck = isCommandAllowed(params.command, this.config);
if (!commandCheck.allowed) {
if (!commandCheck.reason) {
console.error(
debugLogger.error(
'Unexpected: isCommandAllowed returned false without a reason',
);
return `Command is not allowed: ${params.command}`;