MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-06-10 19:37:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): address code review feedback regarding btw rendering and throttle cleanup

Browse Source
This commit is contained in:
Mahima Shanware
2026-04-03 18:44:43 +00:00
parent 96798e32b2
commit c1c8ecef3c
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/components/MainContent.tsx
+3
View File
@@ -436,6 +436,9 @@ export const MainContent = () => {
{(item) => item}
</Static>
{pendingItems}
{/* In alternate buffer mode, the btwDisplayNode is rendered within the ScrollableList
(via virtualizedData) to ensure proper scrolling. In standard mode, it is rendered
here at the bottom of the layout. */}
{btwDisplayNode}
</>
);
packages/cli/src/ui/hooks/useBtw.ts
+17 -4
View File
@@ -148,7 +148,10 @@ export const useBtw = (
break;
}
case GeminiEventType.Error: {
if (flushTimerRef.current) clearTimeout(flushTimerRef.current);
if (flushTimerRef.current) {
clearTimeout(flushTimerRef.current);
flushTimerRef.current = null;
}
flushResponse();
const value = event.value;
@@ -177,7 +180,10 @@ export const useBtw = (
}
case GeminiEventType.Finished:
case GeminiEventType.UserCancelled:
if (flushTimerRef.current) clearTimeout(flushTimerRef.current);
if (flushTimerRef.current) {
clearTimeout(flushTimerRef.current);
flushTimerRef.current = null;
}
flushResponse();
dispatch({ type: 'FINISHED' });
break;
@@ -186,7 +192,10 @@ export const useBtw = (
}
}
} catch (err) {
if (flushTimerRef.current) clearTimeout(flushTimerRef.current);
if (flushTimerRef.current) {
clearTimeout(flushTimerRef.current);
flushTimerRef.current = null;
}
flushResponse();
if (err instanceof Error && err.name === 'AbortError') {
@@ -198,7 +207,10 @@ export const useBtw = (
});
}
} finally {
if (flushTimerRef.current) clearTimeout(flushTimerRef.current);
if (flushTimerRef.current) {
clearTimeout(flushTimerRef.current);
flushTimerRef.current = null;
}
flushResponse();
if (requestIdRef.current === requestId) {
@@ -217,6 +229,7 @@ export const useBtw = (
}
if (flushTimerRef.current) {
clearTimeout(flushTimerRef.current);
flushTimerRef.current = null;
}
},
[],