MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-10 22:21:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

dont attempt to look up releases on github for non-github git uris (#9235)

Browse Source
This commit is contained in:
Jacob MacDonald
2025-09-23 09:52:42 -07:00
committed by GitHub
parent 5151bedf06
commit d8393a06dd
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/cli/src/config/extensions/github.test.ts
View File

@@ -306,6 +306,13 @@ describe('git extension helpers', () => {
);
});
it('should fail on a non-GitHub URL', () => {
const source = 'https://example.com/owner/repo.git';
expect(() => parseGitHubRepoForReleases(source)).toThrow(
'Invalid GitHub repository source: https://example.com/owner/repo.git. Expected "owner/repo" or a github repo uri.',
);
});
it('should parse owner and repo from a shorthand string', () => {
const source = 'owner/repo';
const { owner, repo } = parseGitHubRepoForReleases(source);

2
packages/cli/src/config/extensions/github.ts
View File

@@ -87,7 +87,7 @@ export function parseGitHubRepoForReleases(source: string): {
const parsedUrl = URL.parse(source, 'https://github.com');
// The pathname should be "/owner/repo".
const parts = parsedUrl?.pathname.substring(1).split('/');
if (parts?.length !== 2) {
if (parts?.length !== 2 || parsedUrl?.host !== 'github.com') {
throw new Error(
`Invalid GitHub repository source: ${source}. Expected "owner/repo" or a github repo uri.`,
);