mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-15 14:23:02 -07:00
refactor(core): use extensionId for getExtensionSetting lookup
This commit is contained in:
@@ -1522,16 +1522,16 @@ describe('Server Config (config.ts)', () => {
|
||||
const config = new Config(baseParams);
|
||||
vi.spyOn(config, 'getExtensions').mockReturnValue([
|
||||
{
|
||||
name: 'my-ext',
|
||||
name: 'my-ext-name',
|
||||
version: '1.0',
|
||||
isActive: true,
|
||||
path: '/ext',
|
||||
contextFiles: [],
|
||||
id: 'my-ext',
|
||||
id: 'my-ext-id',
|
||||
},
|
||||
]);
|
||||
expect(
|
||||
config.getExtensionSetting('my-ext', 'some.setting'),
|
||||
config.getExtensionSetting('my-ext-id', 'some.setting'),
|
||||
).toBeUndefined();
|
||||
});
|
||||
|
||||
@@ -1539,12 +1539,12 @@ describe('Server Config (config.ts)', () => {
|
||||
const config = new Config(baseParams);
|
||||
vi.spyOn(config, 'getExtensions').mockReturnValue([
|
||||
{
|
||||
name: 'my-ext',
|
||||
name: 'my-ext-name',
|
||||
version: '1.0',
|
||||
isActive: true,
|
||||
path: '/ext',
|
||||
contextFiles: [],
|
||||
id: 'my-ext',
|
||||
id: 'my-ext-id',
|
||||
resolvedSettings: [
|
||||
{
|
||||
name: 'some.setting',
|
||||
@@ -1555,7 +1555,7 @@ describe('Server Config (config.ts)', () => {
|
||||
],
|
||||
},
|
||||
]);
|
||||
expect(config.getExtensionSetting('my-ext', 'some.setting')).toBe(
|
||||
expect(config.getExtensionSetting('my-ext-id', 'some.setting')).toBe(
|
||||
'custom-val',
|
||||
);
|
||||
});
|
||||
|
||||
@@ -2847,15 +2847,15 @@ export class Config implements McpContext, AgentLoopContext {
|
||||
/**
|
||||
* Retrieves a setting value for a specific extension.
|
||||
*
|
||||
* @param extensionName - The name of the extension.
|
||||
* @param extensionId - The ID of the extension.
|
||||
* @param settingName - The name of the setting to retrieve.
|
||||
*/
|
||||
getExtensionSetting(
|
||||
extensionName: string,
|
||||
extensionId: string,
|
||||
settingName: string,
|
||||
): string | undefined {
|
||||
const ext = this.getExtensions().find(
|
||||
(e) => e.name === extensionName && e.isActive,
|
||||
(e) => e.id === extensionId && e.isActive,
|
||||
);
|
||||
if (!ext || !ext.resolvedSettings) {
|
||||
return undefined;
|
||||
|
||||
Reference in New Issue
Block a user