MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-26 13:04:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): suppress redundant failure note when tool error note is shown (#21078)

Browse Source
This commit is contained in:
N. Taylor Mullen
2026-03-04 13:20:08 -08:00
committed by GitHub
parent 4c85d14f48
commit e63d273e4e
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/hooks/useGeminiStream.test.tsx
+2 -2
View File
@@ -1050,9 +1050,9 @@ describe('useGeminiStream', () => {
); );
expect(noteIndex).toBeGreaterThanOrEqual(0); expect(noteIndex).toBeGreaterThanOrEqual(0);
expect(stopIndex).toBeGreaterThanOrEqual(0); expect(stopIndex).toBeGreaterThanOrEqual(0);
expect(failureHintIndex).toBeGreaterThanOrEqual(0); // The failure hint should NOT be present if the suppressed error note was shown
expect(failureHintIndex).toBe(-1);
expect(noteIndex).toBeLessThan(stopIndex); expect(noteIndex).toBeLessThan(stopIndex);
expect(stopIndex).toBeLessThan(failureHintIndex);
}); });
it('should group multiple cancelled tool call responses into a single history entry', async () => { it('should group multiple cancelled tool call responses into a single history entry', async () => {
packages/cli/src/ui/hooks/useGeminiStream.ts
+4 -1
View File
@@ -596,7 +596,10 @@ export const useGeminiStream = (
if (!isLowErrorVerbosity || config.getDebugMode()) { if (!isLowErrorVerbosity || config.getDebugMode()) {
return; return;
} }
if (lowVerbosityFailureNoteShownRef.current) { if (
lowVerbosityFailureNoteShownRef.current ||
suppressedToolErrorNoteShownRef.current
) {
return; return;
} }