MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-06-12 20:37:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

repro: use single rig.setup and node -e for stability

Browse Source
This commit is contained in:
Taylor Mullen
2026-02-11 10:56:12 -08:00
parent 458e41a79a
commit e6881afd32
1 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/hooks-system.test.ts
+34 -34
View File
@@ -521,7 +521,7 @@ console.log(JSON.stringify({
// 1. Initial setup to establish test directory
rig.setup('BeforeToolSelection Hooks');
const toolConfigJson = {
const toolConfigJson = JSON.stringify({
hookSpecificOutput: {
hookEventName: 'BeforeToolSelection',
toolConfig: {
@@ -529,12 +529,10 @@ console.log(JSON.stringify({
allowedFunctionNames: ['read_file'],
},
},
};
});
const scriptPath = rig.createScript(
'before_tool_selection_hook.cjs',
`console.log(JSON.stringify(${JSON.stringify(toolConfigJson)}));`,
);
// Use node -e to avoid file system and PTY overhead
const nodeCmd = `node -e "console.log(JSON.stringify(${toolConfigJson.replace(/"/g, '\\"')}))"`;
rig.setup('BeforeToolSelection Hooks', {
fakeResponsesPath: join(
@@ -550,7 +548,7 @@ console.log(JSON.stringify({
hooks: [
{
type: 'command',
command: normalizePath(`node "${scriptPath}"`)!,
command: nodeCmd,
timeout: 30000,
},
],
@@ -1772,18 +1770,18 @@ console.log(JSON.stringify({
const enabledMsg = 'EXECUTION_ALLOWED_BY_HOOK_A';
const disabledMsg = 'EXECUTION_BLOCKED_BY_HOOK_B';
const enabledPath = rig.createScript(
'enabled_hook.cjs',
`console.log(JSON.stringify({decision: "allow", systemMessage: "${enabledMsg}"}));`,
);
const enabledJson = JSON.stringify({
decision: 'allow',
systemMessage: enabledMsg,
});
const disabledJson = JSON.stringify({
decision: 'block',
reason: disabledMsg,
});
const disabledPath = rig.createScript(
'disabled_hook.cjs',
`console.log(JSON.stringify({decision: "block", reason: "${disabledMsg}"}));`,
);
const normalizedDisabledCmd = normalizePath(`node "${disabledPath}"`);
const normalizedEnabledCmd = normalizePath(`node "${enabledPath}"`);
// Use node -e to avoid file system and PTY overhead
const enabledCmd = `node -e "console.log(JSON.stringify(${enabledJson.replace(/"/g, '\\"')}))"`;
const disabledCmd = `node -e "console.log(JSON.stringify(${disabledJson.replace(/"/g, '\\"')}))"`;
// 3. Final setup with full settings
rig.setup('Hook Disabling', {
@@ -1793,19 +1791,19 @@ console.log(JSON.stringify({
),
settings: {
enableHooks: true,
disabledHooks: [normalizedDisabledCmd!],
disabledHooks: [disabledCmd],
hooks: {
BeforeTool: [
{
hooks: [
{
type: 'command',
command: normalizedEnabledCmd!,
command: enabledCmd,
timeout: 30000,
},
{
type: 'command',
command: normalizedDisabledCmd!,
command: disabledCmd,
timeout: 30000,
},
],
@@ -1837,40 +1835,42 @@ console.log(JSON.stringify({
});
it.only('should respect disabled hooks across multiple operations', async () => {
// 1. Initial setup to establish test directory
rig.setup('Hook Disabling');
const activeMsg = 'MULTIPLE_OPS_ENABLED_HOOK';
const disabledMsg = 'MULTIPLE_OPS_DISABLED_HOOK';
const activePath = rig.createScript(
'active_hook.cjs',
`console.log(JSON.stringify({decision: "allow", systemMessage: "${activeMsg}"}));`,
);
const disabledPath = rig.createScript(
'disabled_hook.cjs',
`console.log(JSON.stringify({decision: "block", reason: "${disabledMsg}"}));`,
);
const activeJson = JSON.stringify({
decision: 'allow',
systemMessage: activeMsg,
});
const disabledJson = JSON.stringify({
decision: 'block',
reason: disabledMsg,
});
const normalizedDisabledCmd = normalizePath(`node "${disabledPath}"`);
const normalizedActiveCmd = normalizePath(`node "${activePath}"`);
// Use node -e to avoid file system and PTY overhead
const activeCmd = `node -e "console.log(JSON.stringify(${activeJson.replace(/"/g, '\\"')}))"`;
const disabledCmd = `node -e "console.log(JSON.stringify(${disabledJson.replace(/"/g, '\\"')}))"`;
// 3. Final setup with full settings
rig.setup('Hook Disabling', {
settings: {
enableHooks: true,
disabledHooks: [normalizedDisabledCmd!],
disabledHooks: [disabledCmd],
hooks: {
BeforeTool: [
{
hooks: [
{
type: 'command',
command: normalizedActiveCmd!,
command: activeCmd,
timeout: 30000,
},
{
type: 'command',
command: normalizedDisabledCmd!,
command: disabledCmd,
timeout: 30000,
},
],