MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-10 22:21:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): retain user message in history on stream failure (#10608)

Browse Source
This commit is contained in:
Sandy Tao
2025-10-06 16:32:35 -07:00
committed by GitHub
parent 4cd3728039
commit e705f45c5f
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/core/geminiChat.test.ts
View File

@@ -899,9 +899,13 @@ describe('GeminiChat', () => {
expect(mockLogContentRetry).toHaveBeenCalledTimes(1);
expect(mockLogContentRetryFailure).toHaveBeenCalledTimes(1);
// History should be clean, as if the failed turn never happened.
// History should still contain the user message.
const history = chat.getHistory();
expect(history.length).toBe(0);
expect(history.length).toBe(1);
expect(history[0]).toEqual({
role: 'user',
parts: [{ text: 'test' }],
});
});
describe('API error retry behavior', () => {

4
packages/core/src/core/geminiChat.ts
View File

@@ -327,10 +327,6 @@ export class GeminiChat {
),
);
}
// If the stream fails, remove the user message that was added.
if (self.history[self.history.length - 1] === userContent) {
self.history.pop();
}
throw lastError;
}
} finally {