MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-10 22:21:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix test to use faketimer (#12913)

Browse Source
This commit is contained in:
Tommaso Sciortino
2025-11-11 19:03:10 -08:00
committed by GitHub
parent 2abc288c52
commit e8038c727f
1 changed files with 43 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
packages/core/src/utils/llm-edit-fixer.test.ts
View File

@@ -39,11 +39,22 @@ describe('FixLLMEditWithInstruction', () => {
beforeEach(() => {
vi.useFakeTimers();
vi.clearAllMocks();
// Mock AbortSignal.timeout to use setTimeout so it respects fake timers
vi.spyOn(AbortSignal, 'timeout').mockImplementation((ms) => {
const controller = new AbortController();
setTimeout(
() =>
controller.abort(new DOMException('TimeoutError', 'TimeoutError')),
ms,
);
return controller.signal;
});
resetLlmEditFixerCaches_TEST_ONLY(); // Ensure cache is cleared before each test
});
afterEach(() => {
vi.useRealTimers(); // Reset timers after each test
vi.restoreAllMocks();
});
const mockApiResponse: SearchReplaceEdit = {
@@ -329,45 +340,41 @@ describe('FixLLMEditWithInstruction', () => {
});
});
it(
'should return null if the LLM call times out',
{ timeout: 60000 },
async () => {
mockGenerateJson.mockImplementation(
async ({ abortSignal }) =>
// Simulate a long-running operation that never resolves on its own.
// It will only reject when the abort signal is triggered by the timeout.
new Promise((_resolve, reject) => {
if (abortSignal?.aborted) {
return reject(new DOMException('Aborted', 'AbortError'));
}
abortSignal?.addEventListener('abort', () => {
reject(new DOMException('Aborted', 'AbortError'));
});
}),
);
it('should return null if the LLM call times out', async () => {
mockGenerateJson.mockImplementation(
async ({ abortSignal }) =>
// Simulate a long-running operation that never resolves on its own.
// It will only reject when the abort signal is triggered by the timeout.
new Promise((_resolve, reject) => {
if (abortSignal?.aborted) {
return reject(new DOMException('Aborted', 'AbortError'));
}
abortSignal?.addEventListener('abort', () => {
reject(new DOMException('Aborted', 'AbortError'));
});
}),
);
const testPromptId = 'test-prompt-id-timeout';
const testPromptId = 'test-prompt-id-timeout';
const fixPromise = promptIdContext.run(testPromptId, () =>
FixLLMEditWithInstruction(
instruction,
old_string,
new_string,
error,
current_content,
mockBaseLlmClient,
abortSignal,
),
);
const fixPromise = promptIdContext.run(testPromptId, () =>
FixLLMEditWithInstruction(
instruction,
old_string,
new_string,
error,
current_content,
mockBaseLlmClient,
abortSignal,
),
);
// Let the timers advance just past the 40000ms default timeout.
await vi.advanceTimersByTimeAsync(40001);
// Let the timers advance just past the 40000ms default timeout.
await vi.advanceTimersByTimeAsync(40001);
const result = await fixPromise;
const result = await fixPromise;
expect(result).toBeNull();
expect(mockGenerateJson).toHaveBeenCalledOnce();
},
);
expect(result).toBeNull();
expect(mockGenerateJson).toHaveBeenCalledOnce();
});
});