MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-11 06:31:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): allow non-GitHub SCP-styled URLs for extension installation (#13800)

Browse Source 
Co-authored-by: Maksym Kursin <maksym.kursin@dkatalis.com>
This commit is contained in:
Maksym
2025-11-26 00:57:53 +08:00
committed by GitHub
parent 2b41263aa7
commit f2c52f777c
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/cli/src/config/extensions/github.test.ts
View File

@@ -136,8 +136,12 @@ describe('github.ts', () => {
expect(tryParseGithubUrl(url)).toEqual({ owner, repo });
});
it('should return null for non-GitHub URLs', () => {
expect(tryParseGithubUrl('https://gitlab.com/owner/repo')).toBeNull();
it.each([
'https://gitlab.com/owner/repo',
'https://my-git-host.com/owner/group/repo',
'git@gitlab.com:some-group/some-project/some-repo.git',
])('should return null for non-GitHub URLs', (url) => {
expect(tryParseGithubUrl(url)).toBeNull();
});
it('should throw for invalid formats', () => {

12
packages/cli/src/config/extensions/github.ts
View File

@@ -84,9 +84,15 @@ export interface GithubRepoInfo {
}
export function tryParseGithubUrl(source: string): GithubRepoInfo | null {
// First step in normalizing a github ssh URI to the https form.
if (source.startsWith('git@github.com:')) {
source = source.replace('git@github.com:', '');
// Handle SCP-style SSH URLs.
if (source.startsWith('git@')) {
if (source.startsWith('git@github.com:')) {
// It's a GitHub SSH URL, so normalize it for the URL parser.
source = source.replace('git@github.com:', '');
} else {
// It's another provider's SSH URL (e.g., gitlab), so not a GitHub repo.
return null;
}
}
// Default to a github repo path, so `source` can be just an org/repo
const parsedUrl = URL.parse(source, 'https://github.com');