Commit Graph

4497 Commits

Author SHA1 Message Date
Adam Weidman
d5c0212b01 # PR Description: Refactor read_file Tool to Discourage Pagination
## Changes
- Removed `offset` and `limit` parameters from the `read_file` tool and the underlying `processSingleFileContent` utility.
- Updated `read_file` to always return the first 2000 lines of a text file if it exceeds that length.
- Added explicit guidance in the tool's truncation message and description, distinguishing between `grep_search` for pattern finding and `run_shell_command` (specifically `sed`) for extracting specific line ranges.
- Simplified `ProcessedFileReadResult` by removing `linesShown`.
- Updated all internal callers (including `ReadManyFilesTool`, `planCommand`, and `ExitPlanModeDialog`) to match the new signature of `processSingleFileContent`.
- Updated unit tests in `read-file.test.ts` and `fileUtils.test.ts` to verify the new 2000-line default truncation and remove pagination-related test cases.

## Motivation & Feedback
These changes were made to address feedback regarding how the model interacts with large files:
- **Discouraging Inefficient Pagination:** Feedback noted that providing `offset` and `limit` encouraged models to "paginate" through files chunk-by-chunk, which is often an inefficient "looping" behavior.
- **Encouraging Targeted Search:** By removing pagination parameters, we push the model toward more powerful and standard search behaviors. As the feedback stated: *"In my experience it's better to encourage the model to use grep or more complex bash commands to find what it needs."*
- **Compatibility with Search Results:** Models frequently use `grep -n` to find points of interest. Standard Unix tools like `sed` and `grep` are more compatible with 1-based line numbers and sophisticated searching than a manual 0-based `offset`/`limit` implementation.
- **Clarity on Truncation:** Addressed the feedback *"Could be useful to specify how will it be truncated"* by explicitly stating the 2000-line limit in the tool's output and description.
2026-02-09 13:56:02 -05:00
N. Taylor Mullen
da66c7c0d1 chore(evals): update validation_fidelity_pre_existing_errors to USUALLY_PASSES (#18617) 2026-02-09 01:31:22 -08:00
N. Taylor Mullen
fe70052baf fix(evals): update save_memory evals and simplify tool description (#18610) 2026-02-09 01:06:03 -08:00
Andrew Garrett
8cbe851339 Fix newline insertion bug in replace tool (#18595) 2026-02-09 06:37:53 +00:00
N. Taylor Mullen
d45a45d565 chore: strengthen validation guidance in system prompt (#18544) 2026-02-09 05:32:46 +00:00
Jerop Kipruto
69f562b38f docs: Add Plan Mode documentation (#18582) 2026-02-09 03:25:02 +00:00
N. Taylor Mullen
cb73fbf384 feat(core): transition sub-agents to XML format and improve definitions (#18555) 2026-02-09 02:25:04 +00:00
Jerop Kipruto
375c104b32 fix(core): ensure enter_plan_mode tool registration respects experimental.plan (#18587) 2026-02-09 01:57:01 +00:00
N. Taylor Mullen
97a4e62dfa feat(core): conditionally include ctrl+f prompt based on interactive shell setting (#18561) 2026-02-09 00:23:22 +00:00
Tommaso Sciortino
29a6aecffc propagate abortSignal (#18477) 2026-02-08 21:56:26 +00:00
N. Taylor Mullen
92012365ca fix(core): correct escaped interpolation in system prompt (#18557) 2026-02-08 21:08:17 +00:00
Abhi
802bcf4dee refactor(cli): switch useToolScheduler to event-driven engine (#18565) 2026-02-08 20:28:37 +00:00
Jarrod Whelan
4a48d7cf93 feat(cli): truncate shell output in UI history and improve active shell display (#17438) 2026-02-08 08:09:48 +00:00
Abhi
31522045cd refactor(config): remove experimental.enableEventDrivenScheduler setting (#17924) 2026-02-08 04:05:03 +00:00
Abhi
11951592aa feat(core): pause agent timeout budget while waiting for tool confirmation (#18415) 2026-02-08 04:03:47 +00:00
Abhi
bc8ffa6631 feat(context): add remote configuration for tool output masking thresholds (#18553) 2026-02-08 03:04:46 +00:00
N. Taylor Mullen
86bd7dbd4f chore: remove feedback instruction from system prompt (#18560) 2026-02-08 02:22:50 +00:00
N. Taylor Mullen
eee95c509d refactor(core): remove memory tool instructions from Gemini 3 prompt (#18559) 2026-02-08 01:57:53 +00:00
Abhi
a1f2aacd1e feat(core): exempt high-signal tools from output masking (#18545) 2026-02-07 23:56:45 +00:00
Jack Wotherspoon
979bbee485 chore: update colors for ask_user dialog (#18543) 2026-02-07 22:11:51 +00:00
N. Taylor Mullen
7450c926d1 docs: require pr-creator skill for PR generation (#18536) 2026-02-07 21:22:00 +00:00
Jerop Kipruto
be6723ebcc chore: remove redundant planning prompt from final shell (#18528) 2026-02-07 19:45:09 +00:00
Thanh Nguyen
af606aed9b fix(cli): add SS3 Shift+Tab support for Windows terminals (#18187) 2026-02-07 15:38:59 +00:00
Jacob Richman
a37844e5a1 Code review fixes for show question mark pr. (#18480) 2026-02-07 06:35:14 +00:00
g-samroberts
6f1a5bf81d Patch for generate changelog docs yaml file (#18496)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-02-07 03:13:29 +00:00
N. Taylor Mullen
9178b31629 feat(core): overhaul system prompt for rigor, integrity, and intent alignment (#17263) 2026-02-07 03:13:07 +00:00
Sandy Tao
19dc40825e fix(core): expand excludeTools with legacy aliases for renamed tools (#18498) 2026-02-07 00:49:25 +00:00
N. Taylor Mullen
bc9b3052ee fix(cli): reload skills and agents on extension restart (#18411) 2026-02-07 00:40:43 +00:00
Jerop Kipruto
3b0649d408 feat(cli): update approval modes UI (#18476) 2026-02-07 00:23:59 +00:00
Sandy Tao
7409ce5df6 feat(cli): add WebSocket-based network logging and streaming chunk support (#18383) 2026-02-07 00:20:22 +00:00
Jerop Kipruto
e3796d137a fix(core): prevent subagent bypass in plan mode (#18484) 2026-02-06 22:55:00 +00:00
Abhijit Balaji
ee68a10e9c chore: Update build-and-start script to support argument forwarding (#18241) 2026-02-06 22:39:14 +00:00
Sandy Tao
28805a4b2d refactor: simplify tool output truncation to single config (#18446) 2026-02-06 21:41:19 +00:00
joshualitt
fd72a8c40f bug(core): Ensure storage is initialized early, even if config is not. (#18471) 2026-02-06 21:33:13 +00:00
Abhi
63f7e30790 feat(core): implement persistence and resumption for masked tool outputs (#18451) 2026-02-06 21:22:22 +00:00
Tommaso Sciortino
e844d4f45f Refactor atCommandProcessor (#18461) 2026-02-06 20:49:11 +00:00
joshualitt
7a8d6f6095 bug(core): Fix bug when saving plans. (#18465) 2026-02-06 20:45:37 +00:00
Zac Koch
95d79b7cbe fix- windows: add shell: true for spawnSync to fix EINVAL with .cmd editors (#18408) 2026-02-06 19:47:33 +00:00
Jerop Kipruto
601f0606da feat(plan): add positive test case and update eval stability policy (#18457) 2026-02-06 19:45:22 +00:00
Spencer
ad6d3fd902 fix(config): treat system settings as read-only during migration and warn user (#18277) 2026-02-06 19:35:58 +00:00
Dmitry Lyalin
1f1cf756c8 Add shortcuts hint and panel for discoverability (#18035) 2026-02-06 19:33:39 +00:00
Gal Zahavi
ec5836c4d6 fix(cli): improve focus navigation for interactive and background shells (#18343) 2026-02-06 18:36:14 +00:00
Shreya Keshive
f062f56b43 feat(admin): apply MCP allowlist to extensions & gemini mcp list command (#18442) 2026-02-06 18:07:00 +00:00
Sehoon Shon
61d92c4a21 Remove previewFeatures and default to Gemini 3 (#18414) 2026-02-06 18:02:57 +00:00
g-samroberts
1495294cc0 Automatically generate change logs on release (#18401)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-02-06 17:55:46 +00:00
christine betts
d86b1f7b7e Enable extension config by default (#18447) 2026-02-06 17:27:39 +00:00
christine betts
099fea2434 Add extension registry client (#18396) 2026-02-06 17:14:14 +00:00
Jerop Kipruto
1d70aa5c1b feat(plan): add behavioral evals for plan mode (#18437) 2026-02-06 16:51:12 +00:00
joshualitt
6fb3b09003 Shorten temp directory (#17901) 2026-02-06 16:10:17 +00:00
Abhi
30354892b3 feat(core,cli): implement session-linked tool output storage and cleanup (#18416) 2026-02-06 06:36:42 +00:00