jacob314
e2981da430
refactor(cli): simplify command completion orchestration and fix shell cache race
...
- Simplified `useCommandCompletion.tsx` by moving shell-specific tokenization into `useShellCompletion.ts`.
- Reverted most changes to the `useCommandCompletion` `useMemo` block to keep it clean and consistent with other modes.
- Fixed a potential race condition in `useShellCompletion.ts` where `scanPathExecutables` could be called multiple times if it was slow. It now caches the Promise itself.
- Updated tests to match the refined hook interfaces.
2026-02-25 10:35:14 -08:00
jacob314
1dbb9af41c
fix(cli): prioritize shorter command names in shell autocomplete results
2026-02-25 10:00:14 -08:00
jacob314
b4724a1eed
test(cli): update snapshots for shell autocompletion refinements
2026-02-25 09:37:28 -08:00
jacob314
4eea909f28
fix(cli): add Windows shell built-in commands to autocomplete list
...
On Windows, many common commands like `dir`, `copy`, `del`, etc., are internal to `cmd.exe` and do not exist as separate executables on the disk. This updates `scanPathExecutables` to explicitly include these built-ins when running on Windows, ensuring a consistent autocomplete experience for Windows users.
2026-02-25 09:26:38 -08:00
jacob314
af8462f76d
fix(cli): disable shell autocompletion on completely empty prompts
...
To reduce visual noise and distraction, autocompletion is now suppressed when the shell prompt is entirely empty (or only contains whitespace). It remains active as soon as the user starts typing or moves the cursor to a position that would suggest paths/commands.
2026-02-25 09:09:33 -08:00
jacob314
2f4242fb60
fix(cli): prevent autocomplete UI flicker by decoupling disabled state reset from completion refresh
...
When typing outside of shell mode (e.g., using `@` completion), the `useShellCompletion` hook was continuously re-rendering and executing its `useEffect` because `performCompletion` was recreated on every keystroke (since its `query` dependency changed).
Because `enabled` was false, the effect unconditionally called `setSuggestions([])`, rapidly overriding the suggestions populated by `useAtCompletion` and causing severe UI flickering.
This splits the effect to ensure `setSuggestions([])` is only called once when `enabled` becomes false, stabilizing the suggestions list.
2026-02-25 08:58:31 -08:00
jacob314
aeecf5a9e7
fix(cli): prevent auto-submit on Enter when navigating to first shell autocomplete suggestion
...
When using shell autocomplete, pressing Down then Up returns the activeSuggestionIndex to 0. If the first suggestion happened to be an exact match, the InputPrompt would bypass the normal autocomplete logic and eagerly submit the prompt on Enter because it ignored whether the user had actively navigated.
This fix updates the isPerfectMatch check to require that the user has not navigated the suggestions list, ensuring that explicitly selected items always autocomplete instead of submitting.
2026-02-25 08:23:53 -08:00
MD. MOHIBUR RAHMAN
dfa5c79a47
refactor(cli): centralize token parsing in useCommandCompletion to optimize re-renders
2026-02-24 05:22:51 +06:00
MD. MOHIBUR RAHMAN
d6770d2ae9
fix(cli): escape executables in shell autocompletion to prevent command injection
2026-02-24 05:06:10 +06:00
MD. MOHIBUR RAHMAN
c1d7bc4c8c
fix(cli): escape npm script names in shell autocompletion to prevent command injection
2026-02-24 05:04:27 +06:00
MD. MOHIBUR RAHMAN
39b393abfb
fix(cli): prevent command injection by escaping git branch suggestions
2026-02-24 04:25:16 +06:00
MD. MOHIBUR RAHMAN
5b3819073f
fix(cli): add missing shell metacharacters (\n, \r, \t, \\) to escape regex
2026-02-24 04:14:54 +06:00
MD. MOHIBUR RAHMAN
926afab788
fix(cli): improve shell completion for dotfiles, spaces, and quotes
2026-02-24 03:41:33 +06:00
MD. MOHIBUR RAHMAN
555b95eb09
feat(cli): add context-sensitive shell completions for git and npm ( #2492 )
2026-02-24 02:52:20 +06:00
MD. MOHIBUR RAHMAN
0c6ebbd1f5
feat(cli): implement interactive shell autocompletion ( #2492 )
2026-02-24 01:49:30 +06:00
Sandy Tao
25803e05fd
fix(bundling): copy devtools package to bundle for runtime resolution ( #19766 )
2026-02-23 18:40:41 +00:00
Himanshu Soni
774ae220be
fix(core): prevent state corruption in McpClientManager during collis ( #19782 )
2026-02-23 18:35:31 +00:00
Tommaso Sciortino
813e0c18ac
Allow ask headers longer than 16 chars ( #20041 )
2026-02-23 18:26:59 +00:00
Gal Zahavi
3f6cec22e6
chore: restrict gemini-automted-issue-triage to only allow echo ( #20047 )
2026-02-23 18:24:34 +00:00
Sri Pasumarthi
3966f3c053
feat: Map tool kinds to explicit ACP.ToolKind values and update test … ( #19547 )
2026-02-23 18:22:05 +00:00
sinisterchill
2e3cbd6363
fix(core): prevent OAuth server crash on unexpected requests ( #19668 )
2026-02-23 18:03:31 +00:00
Adib234
8b1dc15182
fix(plan): allow plan mode writes on Windows and fix prompt paths ( #19658 )
2026-02-23 17:48:50 +00:00
owenofbrien
fa9aee2bf0
Fix for silent failures in non-interactive mode ( #19905 )
2026-02-23 17:35:13 +00:00
Sam Roberts
6628cbb39d
Updates command reference and /stats command. ( #19794 )
2026-02-23 17:13:24 +00:00
Sehoon Shon
aa9163da60
feat(core): add policy chain support for Gemini 3.1 ( #19991 )
2026-02-23 15:13:48 +00:00
Sehoon Shon
ec0f23ae03
fix(core): increase default retry attempts and add quota error backoff ( #19949 )
2026-02-23 15:13:34 +00:00
nityam
ac04c388e0
Fix: Persist manual model selection on restart #19864 ( #19891 )
2026-02-23 03:44:00 +00:00
Abhi
621ddbe744
refactor(core): move session conversion logic to core ( #19972 )
2026-02-23 01:18:07 +00:00
Sehoon Shon
c537fd5aec
refactor(config): remove enablePromptCompletion from settings ( #19974 )
2026-02-22 19:10:20 -05:00
Shivangi Sharma
a91bc60e18
fix(core): add uniqueness guard to edit tool ( #19890 )
...
Co-authored-by: Bryan Morgan <bryanmorgan@google.com >
2026-02-22 20:24:58 +00:00
Nick Salerni
faa1ec3044
fix(core): prevent omission placeholder deletions in replace/write_file ( #19870 )
...
Co-authored-by: Bryan Morgan <bryanmorgan@google.com >
2026-02-22 19:58:31 +00:00
Bryan Morgan
d96bd05d36
fix(core): allow any preview model in quota access check ( #19867 )
2026-02-22 12:53:24 +00:00
Adib234
84666e1bbc
fix(plan): time share by approval mode dashboard reporting negative time shares ( #19847 )
2026-02-22 00:32:57 +00:00
N. Taylor Mullen
a7d851146a
feat(core): remove unnecessary login verbiage from Code Assist auth ( #19861 )
2026-02-21 21:55:11 +00:00
Abhi
acb7f577de
chore(lint): fix lint errors seen when running npm run lint ( #19844 )
2026-02-21 18:33:25 +00:00
Abhi
d2d345f41a
fix(cli): filter subagent sessions from resume history ( #19698 )
2026-02-21 17:41:27 +00:00
Christian Gunderman
dfd7721e69
Disallow unsafe returns. ( #19767 )
2026-02-21 01:12:56 +00:00
matt korwel
09218572d0
refactor(core): remove unsafe type assertions in error utils (Phase 1.1) ( #19750 )
2026-02-21 01:00:57 +00:00
Christian Gunderman
5d98ed5820
Utilize pipelining of grep_search -> read_file to eliminate turns ( #19574 )
2026-02-21 00:36:10 +00:00
Jarrod Whelan
727f9b67b1
feat(cli): improve CTRL+O experience for both standard and alternate screen buffer (ASB) modes ( #19010 )
...
Co-authored-by: jacob314 <jacob314@gmail.com >
2026-02-21 00:26:11 +00:00
Adam Weidman
547f5d45f5
feat(core): migrate read_file to 1-based start_line/end_line parameters ( #19526 )
2026-02-20 22:59:18 +00:00
Christian Gunderman
58d637f919
Disallow and suppress unsafe assignment ( #19736 )
2026-02-20 22:28:55 +00:00
Sehoon Shon
b746524a1b
fix(cli): re-enable CLI banner ( #19741 )
2026-02-20 22:21:26 +00:00
Abhijit Balaji
c5baf39dbd
feat(policy): repurpose "Always Allow" persistence to workspace level ( #19707 )
2026-02-20 22:07:20 +00:00
Sehoon Shon
b48970da15
fix(cli): use getDisplayString for manual model selection in dialog ( #19726 )
2026-02-20 22:03:32 +00:00
Jacob Richman
9a8e5d3940
fix(cli): extensions dialog UX polish ( #19685 )
2026-02-20 21:08:24 +00:00
Jacob Richman
089aec8b8d
feat(cli): make JetBrains warning more specific ( #19687 )
2026-02-20 21:06:35 +00:00
Christian Gunderman
b7555ab1e1
Fix unsafe assertions in code_assist folder. ( #19706 )
...
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-02-20 20:44:23 +00:00
Emily Hedlund
c04602f209
fix(core): restore auth consent in headless mode and add unit tests ( #19689 )
2026-02-20 20:31:43 +00:00
Emily Hedlund
a01d7e9a05
security: implement deceptive URL detection and disclosure in tool confirmations ( #19288 )
2026-02-20 20:21:31 +00:00