mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-07-27 02:01:00 -07:00
Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0ef8a5c821 | |||
| 3d5d5b8af0 | |||
| dec805083d | |||
| 5496862e6e | |||
| 4b676775d7 | |||
| c173f77052 |
@@ -23,7 +23,6 @@ const external = [
|
||||
'@lydell/node-pty-linux-x64',
|
||||
'@lydell/node-pty-win32-arm64',
|
||||
'@lydell/node-pty-win32-x64',
|
||||
'node-fetch',
|
||||
];
|
||||
|
||||
esbuild
|
||||
|
||||
Generated
+7
-7
@@ -1,12 +1,12 @@
|
||||
{
|
||||
"name": "@google/gemini-cli",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "@google/gemini-cli",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"workspaces": [
|
||||
"packages/*"
|
||||
],
|
||||
@@ -16107,7 +16107,7 @@
|
||||
},
|
||||
"packages/a2a-server": {
|
||||
"name": "@google/gemini-cli-a2a-server",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"dependencies": {
|
||||
"@a2a-js/sdk": "^0.3.2",
|
||||
"@google-cloud/storage": "^7.16.0",
|
||||
@@ -16378,7 +16378,7 @@
|
||||
},
|
||||
"packages/cli": {
|
||||
"name": "@google/gemini-cli",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"dependencies": {
|
||||
"@google/gemini-cli-core": "file:../core",
|
||||
"@google/genai": "1.16.0",
|
||||
@@ -16569,7 +16569,7 @@
|
||||
},
|
||||
"packages/core": {
|
||||
"name": "@google/gemini-cli-core",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"dependencies": {
|
||||
"@google/genai": "1.16.0",
|
||||
"@lvce-editor/ripgrep": "^1.6.0",
|
||||
@@ -16709,7 +16709,7 @@
|
||||
},
|
||||
"packages/test-utils": {
|
||||
"name": "@google/gemini-cli-test-utils",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"license": "Apache-2.0",
|
||||
"devDependencies": {
|
||||
"typescript": "^5.3.3"
|
||||
@@ -16720,7 +16720,7 @@
|
||||
},
|
||||
"packages/vscode-ide-companion": {
|
||||
"name": "gemini-cli-vscode-ide-companion",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"license": "LICENSE",
|
||||
"dependencies": {
|
||||
"@modelcontextprotocol/sdk": "^1.15.1",
|
||||
|
||||
+2
-2
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@google/gemini-cli",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"engines": {
|
||||
"node": ">=20.0.0"
|
||||
},
|
||||
@@ -14,7 +14,7 @@
|
||||
"url": "git+https://github.com/google-gemini/gemini-cli.git"
|
||||
},
|
||||
"config": {
|
||||
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.3.1"
|
||||
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.4.0-preview.2"
|
||||
},
|
||||
"scripts": {
|
||||
"start": "node scripts/start.js",
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@google/gemini-cli-a2a-server",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"private": true,
|
||||
"description": "Gemini CLI A2A Server",
|
||||
"repository": {
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@google/gemini-cli",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"description": "Gemini CLI",
|
||||
"repository": {
|
||||
"type": "git",
|
||||
@@ -25,7 +25,7 @@
|
||||
"dist"
|
||||
],
|
||||
"config": {
|
||||
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.3.1"
|
||||
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.4.0-preview.2"
|
||||
},
|
||||
"dependencies": {
|
||||
"@google/gemini-cli-core": "file:../core",
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@google/gemini-cli-core",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"description": "Gemini CLI Core",
|
||||
"repository": {
|
||||
"type": "git",
|
||||
|
||||
@@ -416,9 +416,9 @@ describe('GeminiChat', () => {
|
||||
expect(modelTurn?.parts![0]!.functionCall).toBeDefined();
|
||||
});
|
||||
|
||||
it('should succeed if the stream ends with an empty part but has a valid finishReason', async () => {
|
||||
// 1. Mock a stream that ends with an invalid part but has a 'STOP' finish reason.
|
||||
const streamWithValidFinish = (async function* () {
|
||||
it('should fail if the stream ends with an empty part and has no finishReason', async () => {
|
||||
// 1. Mock a stream that ends with an invalid part and has no finish reason.
|
||||
const streamWithNoFinish = (async function* () {
|
||||
yield {
|
||||
candidates: [
|
||||
{
|
||||
@@ -429,7 +429,7 @@ describe('GeminiChat', () => {
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
// This second chunk is invalid, but the finishReason should save it from retrying.
|
||||
// This second chunk is invalid and has no finishReason, so it should fail.
|
||||
yield {
|
||||
candidates: [
|
||||
{
|
||||
@@ -437,6 +437,50 @@ describe('GeminiChat', () => {
|
||||
role: 'model',
|
||||
parts: [{ text: '' }],
|
||||
},
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})();
|
||||
|
||||
vi.mocked(mockModelsModule.generateContentStream).mockResolvedValue(
|
||||
streamWithNoFinish,
|
||||
);
|
||||
|
||||
// 2. Action & Assert: The stream should fail because there's no finish reason.
|
||||
const stream = await chat.sendMessageStream(
|
||||
{ message: 'test message' },
|
||||
'prompt-id-no-finish-empty-end',
|
||||
);
|
||||
await expect(
|
||||
(async () => {
|
||||
for await (const _ of stream) {
|
||||
/* consume stream */
|
||||
}
|
||||
})(),
|
||||
).rejects.toThrow(EmptyStreamError);
|
||||
});
|
||||
|
||||
it('should succeed if the stream ends with an invalid part but has a finishReason and contained a valid part', async () => {
|
||||
// 1. Mock a stream that sends a valid chunk, then an invalid one, but has a finish reason.
|
||||
const streamWithInvalidEnd = (async function* () {
|
||||
yield {
|
||||
candidates: [
|
||||
{
|
||||
content: {
|
||||
role: 'model',
|
||||
parts: [{ text: 'Initial valid content...' }],
|
||||
},
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
// This second chunk is invalid, but the response has a finishReason.
|
||||
yield {
|
||||
candidates: [
|
||||
{
|
||||
content: {
|
||||
role: 'model',
|
||||
parts: [{ text: '' }], // Invalid part
|
||||
},
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
@@ -444,14 +488,13 @@ describe('GeminiChat', () => {
|
||||
})();
|
||||
|
||||
vi.mocked(mockModelsModule.generateContentStream).mockResolvedValue(
|
||||
streamWithValidFinish,
|
||||
streamWithInvalidEnd,
|
||||
);
|
||||
|
||||
// 2. Action & Assert: The stream should complete successfully because the valid
|
||||
// finishReason overrides the invalid final chunk.
|
||||
// 2. Action & Assert: The stream should complete without throwing an error.
|
||||
const stream = await chat.sendMessageStream(
|
||||
{ message: 'test message' },
|
||||
'prompt-id-valid-finish-empty-end',
|
||||
'prompt-id-valid-then-invalid-end',
|
||||
);
|
||||
await expect(
|
||||
(async () => {
|
||||
@@ -461,12 +504,12 @@ describe('GeminiChat', () => {
|
||||
})(),
|
||||
).resolves.not.toThrow();
|
||||
|
||||
// 3. Verify history was recorded correctly
|
||||
// 3. Verify history was recorded correctly with only the valid part.
|
||||
const history = chat.getHistory();
|
||||
expect(history.length).toBe(2);
|
||||
expect(history.length).toBe(2); // user turn + model turn
|
||||
const modelTurn = history[1]!;
|
||||
expect(modelTurn?.parts?.length).toBe(1); // The empty part is discarded
|
||||
expect(modelTurn?.parts![0]!.text).toBe('Initial content...');
|
||||
expect(modelTurn?.parts?.length).toBe(1);
|
||||
expect(modelTurn?.parts![0]!.text).toBe('Initial valid content...');
|
||||
});
|
||||
it('should not consolidate text into a part that also contains a functionCall', async () => {
|
||||
// 1. Mock the API to stream a malformed part followed by a valid text part.
|
||||
@@ -542,7 +585,10 @@ describe('GeminiChat', () => {
|
||||
// as the important part is consolidating what comes after.
|
||||
yield {
|
||||
candidates: [
|
||||
{ content: { role: 'model', parts: [{ text: ' World!' }] } },
|
||||
{
|
||||
content: { role: 'model', parts: [{ text: ' World!' }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})();
|
||||
@@ -645,6 +691,7 @@ describe('GeminiChat', () => {
|
||||
{ text: 'This is the visible text that should not be lost.' },
|
||||
],
|
||||
},
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
@@ -705,7 +752,10 @@ describe('GeminiChat', () => {
|
||||
const emptyStreamResponse = (async function* () {
|
||||
yield {
|
||||
candidates: [
|
||||
{ content: { role: 'model', parts: [{ thought: true }] } },
|
||||
{
|
||||
content: { role: 'model', parts: [{ thought: true }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})();
|
||||
@@ -975,7 +1025,12 @@ describe('GeminiChat', () => {
|
||||
// Second attempt (the retry): A minimal valid stream.
|
||||
(async function* () {
|
||||
yield {
|
||||
candidates: [{ content: { parts: [{ text: 'Success' }] } }],
|
||||
candidates: [
|
||||
{
|
||||
content: { parts: [{ text: 'Success' }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})(),
|
||||
);
|
||||
@@ -1012,7 +1067,10 @@ describe('GeminiChat', () => {
|
||||
(async function* () {
|
||||
yield {
|
||||
candidates: [
|
||||
{ content: { parts: [{ text: 'Successful response' }] } },
|
||||
{
|
||||
content: { parts: [{ text: 'Successful response' }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})(),
|
||||
@@ -1123,7 +1181,12 @@ describe('GeminiChat', () => {
|
||||
// Second attempt succeeds
|
||||
(async function* () {
|
||||
yield {
|
||||
candidates: [{ content: { parts: [{ text: 'Second answer' }] } }],
|
||||
candidates: [
|
||||
{
|
||||
content: { parts: [{ text: 'Second answer' }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})(),
|
||||
);
|
||||
@@ -1272,6 +1335,7 @@ describe('GeminiChat', () => {
|
||||
content: {
|
||||
parts: [{ text: 'Successful response after empty' }],
|
||||
},
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
@@ -1333,13 +1397,23 @@ describe('GeminiChat', () => {
|
||||
} as unknown as GenerateContentResponse;
|
||||
await firstStreamContinuePromise; // Pause the stream
|
||||
yield {
|
||||
candidates: [{ content: { parts: [{ text: ' part 2' }] } }],
|
||||
candidates: [
|
||||
{
|
||||
content: { parts: [{ text: ' part 2' }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})();
|
||||
|
||||
const secondStreamGenerator = (async function* () {
|
||||
yield {
|
||||
candidates: [{ content: { parts: [{ text: 'second response' }] } }],
|
||||
candidates: [
|
||||
{
|
||||
content: { parts: [{ text: 'second response' }] },
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
})();
|
||||
|
||||
@@ -1424,6 +1498,7 @@ describe('GeminiChat', () => {
|
||||
content: {
|
||||
parts: [{ text: 'Successful final response' }],
|
||||
},
|
||||
finishReason: 'STOP',
|
||||
},
|
||||
],
|
||||
} as unknown as GenerateContentResponse;
|
||||
|
||||
@@ -612,23 +612,18 @@ export class GeminiChat {
|
||||
): AsyncGenerator<GenerateContentResponse> {
|
||||
const modelResponseParts: Part[] = [];
|
||||
let hasReceivedAnyChunk = false;
|
||||
let hasReceivedValidChunk = false;
|
||||
let hasToolCall = false;
|
||||
let lastChunk: GenerateContentResponse | null = null;
|
||||
|
||||
let isStreamInvalid = false;
|
||||
let firstInvalidChunkEncountered = false;
|
||||
let validChunkAfterInvalidEncountered = false;
|
||||
let lastChunkIsInvalid = false;
|
||||
|
||||
for await (const chunk of streamResponse) {
|
||||
hasReceivedAnyChunk = true;
|
||||
lastChunk = chunk;
|
||||
|
||||
if (isValidResponse(chunk)) {
|
||||
if (firstInvalidChunkEncountered) {
|
||||
// A valid chunk appeared *after* an invalid one.
|
||||
validChunkAfterInvalidEncountered = true;
|
||||
}
|
||||
|
||||
hasReceivedValidChunk = true;
|
||||
lastChunkIsInvalid = false;
|
||||
const content = chunk.candidates?.[0]?.content;
|
||||
if (content?.parts) {
|
||||
if (content.parts.some((part) => part.thought)) {
|
||||
@@ -646,8 +641,7 @@ export class GeminiChat {
|
||||
this.config,
|
||||
new InvalidChunkEvent('Invalid chunk received from stream.'),
|
||||
);
|
||||
isStreamInvalid = true;
|
||||
firstInvalidChunkEncountered = true;
|
||||
lastChunkIsInvalid = true;
|
||||
}
|
||||
|
||||
// Record token usage if this chunk has usageMetadata
|
||||
@@ -662,27 +656,24 @@ export class GeminiChat {
|
||||
throw new EmptyStreamError('Model stream completed without any chunks.');
|
||||
}
|
||||
|
||||
// --- FIX: The entire validation block was restructured for clarity and correctness ---
|
||||
// Only apply complex validation if an invalid chunk was actually found.
|
||||
if (isStreamInvalid) {
|
||||
// Fail immediately if an invalid chunk was not the absolute last chunk.
|
||||
if (validChunkAfterInvalidEncountered) {
|
||||
throw new EmptyStreamError(
|
||||
'Model stream had invalid intermediate chunks without a tool call.',
|
||||
);
|
||||
}
|
||||
const hasFinishReason = lastChunk?.candidates?.some(
|
||||
(candidate) => candidate.finishReason,
|
||||
);
|
||||
|
||||
if (!hasToolCall) {
|
||||
// If the *only* invalid part was the last chunk, we still check its finish reason.
|
||||
const finishReason = lastChunk?.candidates?.[0]?.finishReason;
|
||||
const isSuccessfulFinish =
|
||||
finishReason === 'STOP' || finishReason === 'MAX_TOKENS';
|
||||
if (!isSuccessfulFinish) {
|
||||
throw new EmptyStreamError(
|
||||
'Model stream ended with an invalid chunk and a failed finish reason.',
|
||||
);
|
||||
}
|
||||
}
|
||||
// Stream validation logic: A stream is considered successful if:
|
||||
// 1. There's a tool call (tool calls can end without explicit finish reasons), OR
|
||||
// 2. There's a finish reason AND the last chunk is valid (or we haven't received any valid chunks)
|
||||
//
|
||||
// We throw an error only when there's no tool call AND:
|
||||
// - No finish reason, OR
|
||||
// - Last chunk is invalid after receiving valid content
|
||||
if (
|
||||
!hasToolCall &&
|
||||
(!hasFinishReason || (lastChunkIsInvalid && !hasReceivedValidChunk))
|
||||
) {
|
||||
throw new EmptyStreamError(
|
||||
'Model stream ended with an invalid chunk or missing finish reason.',
|
||||
);
|
||||
}
|
||||
|
||||
// Record model response text from the collected parts
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@google/gemini-cli-test-utils",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"private": true,
|
||||
"main": "src/index.ts",
|
||||
"license": "Apache-2.0",
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
"name": "gemini-cli-vscode-ide-companion",
|
||||
"displayName": "Gemini CLI Companion",
|
||||
"description": "Enable Gemini CLI with direct access to your IDE workspace.",
|
||||
"version": "0.3.1",
|
||||
"version": "0.4.0-preview.2",
|
||||
"publisher": "google",
|
||||
"icon": "assets/icon.png",
|
||||
"repository": {
|
||||
|
||||
Reference in New Issue
Block a user