Compare commits

..

2 Commits

Author SHA1 Message Date
amelidev 5024443c72 fix(core): resolve swallowed directory mismatch in IDE connections (#28729)
Co-authored-by: David Pierce <davidapierce@google.com>
2026-08-11 22:01:47 +00:00
amelidev 58ba19945a fix(core): dynamically resolve Cloud Workstations proxy redirect URI for OAuth flows (#28688)
Co-authored-by: David Pierce <davidapierce@google.com>
2026-08-11 19:28:38 +00:00
17 changed files with 786 additions and 140 deletions
+9 -9
View File
@@ -1,12 +1,12 @@
{
"name": "@google/gemini-cli",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@google/gemini-cli",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"workspaces": [
"packages/*"
],
@@ -17782,7 +17782,7 @@
},
"packages/a2a-server": {
"name": "@google/gemini-cli-a2a-server",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"dependencies": {
"@a2a-js/sdk": "0.3.11",
"@google-cloud/storage": "7.19.0",
@@ -18242,7 +18242,7 @@
},
"packages/cli": {
"name": "@google/gemini-cli",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "Apache-2.0",
"dependencies": {
"@agentclientprotocol/sdk": "0.16.1",
@@ -18458,7 +18458,7 @@
},
"packages/core": {
"name": "@google/gemini-cli-core",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "Apache-2.0",
"dependencies": {
"@a2a-js/sdk": "0.3.11",
@@ -19131,7 +19131,7 @@
},
"packages/devtools": {
"name": "@google/gemini-cli-devtools",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "Apache-2.0",
"dependencies": {
"ws": "8.16.0"
@@ -19167,7 +19167,7 @@
},
"packages/sdk": {
"name": "@google/gemini-cli-sdk",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "Apache-2.0",
"dependencies": {
"@google/gemini-cli-core": "file:../core",
@@ -19506,7 +19506,7 @@
},
"packages/test-utils": {
"name": "@google/gemini-cli-test-utils",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "Apache-2.0",
"dependencies": {
"@google/gemini-cli-core": "file:../core",
@@ -19524,7 +19524,7 @@
},
"packages/vscode-ide-companion": {
"name": "gemini-cli-vscode-ide-companion",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "LICENSE",
"dependencies": {
"@modelcontextprotocol/sdk": "1.23.0",
+2 -2
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"engines": {
"node": ">=20.0.0"
},
@@ -14,7 +14,7 @@
"url": "git+https://github.com/google-gemini/gemini-cli.git"
},
"config": {
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.56.0-preview.1"
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.56.0-nightly.20260806.g761f604c1"
},
"scripts": {
"start": "cross-env NODE_ENV=development node scripts/start.js",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli-a2a-server",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"description": "Gemini CLI A2A Server",
"repository": {
"type": "git",
+2 -2
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"description": "Gemini CLI",
"license": "Apache-2.0",
"repository": {
@@ -27,7 +27,7 @@
"dist"
],
"config": {
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.56.0-preview.1"
"sandboxImageUri": "us-docker.pkg.dev/gemini-code-dev/gemini-cli/sandbox:0.56.0-nightly.20260806.g761f604c1"
},
"dependencies": {
"@agentclientprotocol/sdk": "0.16.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli-core",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"description": "Gemini CLI Core",
"license": "Apache-2.0",
"repository": {
@@ -31,6 +31,21 @@ vi.mock('node:fs', async (importOriginal) => {
...actual.promises,
readFile: vi.fn(),
readdir: vi.fn(),
realpath: vi.fn((p) => Promise.resolve(p)),
stat: vi.fn(() =>
Promise.resolve({ uid: process.getuid ? process.getuid() : 1000 }),
),
open: vi.fn((filePath: string) =>
Promise.resolve({
stat: () => fs.promises.stat(filePath),
readFile: (options?: string | { encoding?: string }) =>
fs.promises.readFile(
filePath,
options as unknown as BufferEncoding | undefined,
),
close: () => Promise.resolve(),
} as unknown as fs.promises.FileHandle),
),
},
realpathSync: (p: string) => p,
existsSync: vi.fn(() => false),
@@ -430,6 +445,141 @@ describe('ide-connection-utils', () => {
expect(result).toEqual(config2);
});
it('should NOT filter out config if all found config files are mismatched/invalid workspaces, returning the best sorted match so that the correct Directory Mismatch error is raised downstream', async () => {
const invalidConfig1 = {
port: '1111',
workspacePath: '/invalid/workspace1',
};
const invalidConfig2 = {
port: '2222',
workspacePath: '/invalid/workspace2',
};
vi.mocked(fs.promises.readFile).mockRejectedValueOnce(
new Error('not found'),
);
(
vi.mocked(fs.promises.readdir) as Mock<
(path: fs.PathLike) => Promise<string[]>
>
).mockResolvedValue([
'gemini-ide-server-12345-111.json',
'gemini-ide-server-12345-222.json',
]);
vi.mocked(fs.promises.readFile)
.mockResolvedValueOnce(JSON.stringify(invalidConfig1))
.mockResolvedValueOnce(JSON.stringify(invalidConfig2));
const result = await getConnectionConfigFromFile(12345);
expect(result).toEqual(invalidConfig1);
});
it('should prioritize the config matching the port from the environment variable when all found config files are mismatched/invalid workspaces', async () => {
vi.stubEnv('GEMINI_CLI_IDE_SERVER_PORT', '2222');
const invalidConfig1 = {
port: '1111',
workspacePath: '/invalid/workspace1',
};
const invalidConfig2 = {
port: '2222',
workspacePath: '/invalid/workspace2',
};
vi.mocked(fs.promises.readFile).mockRejectedValueOnce(
new Error('not found'),
);
(
vi.mocked(fs.promises.readdir) as Mock<
(path: fs.PathLike) => Promise<string[]>
>
).mockResolvedValue([
'gemini-ide-server-12345-111.json',
'gemini-ide-server-12345-222.json',
]);
vi.mocked(fs.promises.readFile)
.mockResolvedValueOnce(JSON.stringify(invalidConfig1))
.mockResolvedValueOnce(JSON.stringify(invalidConfig2));
const result = await getConnectionConfigFromFile(12345);
expect(result).toEqual(invalidConfig2);
});
it.runIf(process.getuid !== undefined)(
'should reject and ignore config files owned by a different user UID to prevent hijacking/information disclosure',
async () => {
const config1 = {
port: '1111',
workspacePath: '/test/workspace',
};
vi.mocked(fs.promises.readFile).mockRejectedValueOnce(
new Error('not found'),
);
(
vi.mocked(fs.promises.readdir) as Mock<
(path: fs.PathLike) => Promise<string[]>
>
).mockResolvedValue(['gemini-ide-server-12345-111.json']);
vi.mocked(fs.promises.readFile).mockResolvedValueOnce(
JSON.stringify(config1),
);
const otherUid = (process.getuid ? process.getuid() : 1000) + 1;
vi.mocked(fs.promises.stat).mockResolvedValueOnce({
uid: otherUid,
} as unknown as fs.Stats);
const result = await getConnectionConfigFromFile(12345);
expect(result).toBeUndefined();
},
);
it('should accept and parse config files owned by the current user UID', async () => {
const config1 = {
port: '1111',
workspacePath: '/test/workspace',
};
vi.mocked(fs.promises.readFile).mockRejectedValueOnce(
new Error('not found'),
);
(
vi.mocked(fs.promises.readdir) as Mock<
(path: fs.PathLike) => Promise<string[]>
>
).mockResolvedValue(['gemini-ide-server-12345-111.json']);
vi.mocked(fs.promises.readFile).mockResolvedValueOnce(
JSON.stringify(config1),
);
const currentUid = process.getuid ? process.getuid() : 1000;
vi.mocked(fs.promises.stat).mockResolvedValueOnce({
uid: currentUid,
} as unknown as fs.Stats);
const result = await getConnectionConfigFromFile(12345);
expect(result).toEqual(config1);
});
it('should reject and ignore config files if fs.promises.open throws an error', async () => {
vi.mocked(fs.promises.readFile).mockRejectedValueOnce(
new Error('not found'),
);
(
vi.mocked(fs.promises.readdir) as Mock<
(path: fs.PathLike) => Promise<string[]>
>
).mockResolvedValue(['gemini-ide-server-12345-111.json']);
vi.mocked(fs.promises.open).mockRejectedValueOnce(
new Error('symlink loop / permission denied'),
);
const result = await getConnectionConfigFromFile(12345);
expect(result).toBeUndefined();
});
});
describe('validateWorkspacePath', () => {
+60 -13
View File
@@ -109,6 +109,26 @@ export function getStdioConfigFromEnv(): StdioConfig | undefined {
const IDE_SERVER_FILE_REGEX = /^gemini-ide-server-(\d+)-\d+\.json$/;
async function verifyAndReadFile(
filePath: string,
): Promise<string | undefined> {
let handle: fs.promises.FileHandle | undefined;
try {
handle = await fs.promises.open(filePath, 'r');
const stat = await handle.stat();
if (process.getuid && stat.uid !== process.getuid()) {
return undefined;
}
return await handle.readFile('utf8');
} catch {
return undefined;
} finally {
if (handle) {
await handle.close();
}
}
}
export async function getConnectionConfigFromFile(
pid: number,
): Promise<
@@ -122,7 +142,10 @@ export async function getConnectionConfigFromFile(
'ide',
`gemini-ide-server-${pid}.json`,
);
const portFileContents = await fs.promises.readFile(portFile, 'utf8');
const portFileContents = await verifyAndReadFile(portFile);
if (!portFileContents) {
throw new Error('Verification failed or file not found');
}
const parsed: unknown = JSON.parse(portFileContents);
type ConfigType = ConnectionConfig & {
workspacePath?: string;
@@ -164,23 +187,21 @@ export async function getConnectionConfigFromFile(
sortConnectionFiles(matchingFiles, pid);
let fileContents: string[];
try {
fileContents = await Promise.all(
matchingFiles.map((file) =>
fs.promises.readFile(path.join(portFileDir, file), 'utf8'),
),
);
} catch (e) {
logger.debug('Failed to read IDE connection config file(s):', e);
return undefined;
}
const fileContents = await Promise.all(
matchingFiles.map((file) =>
verifyAndReadFile(path.join(portFileDir, file)),
),
);
const parsedContents = fileContents.map(
(
content,
):
| (ConnectionConfig & { workspacePath?: string; ideInfo?: IdeInfo })
| undefined => {
if (!content) {
return undefined;
}
try {
const parsed: unknown = JSON.parse(content);
type ConfigType = ConnectionConfig & {
@@ -219,6 +240,31 @@ export async function getConnectionConfigFromFile(
);
if (validWorkspaces.length === 0) {
// If no workspace matches the current CWD, but we found and parsed
// valid connection config file(s), return the best-sorted config.
// This lets downstream connection logic raise a helpful, detailed
// "Directory mismatch" warning instead of a generic connection error.
let fileIndex = -1;
const portFromEnv = getPortFromEnv();
if (portFromEnv) {
fileIndex = parsedContents.findIndex(
(content) =>
!!content &&
content.port !== undefined &&
String(content.port) === portFromEnv,
);
}
if (fileIndex === -1) {
fileIndex = parsedContents.findIndex((content) => !!content);
}
if (fileIndex !== -1) {
const selected = parsedContents[fileIndex]!;
logger.debug(
`Selected best mismatched IDE connection file: ${matchingFiles[fileIndex]}`,
);
return selected;
}
return undefined;
}
@@ -234,7 +280,8 @@ export async function getConnectionConfigFromFile(
const portFromEnv = getPortFromEnv();
if (portFromEnv) {
const matchingPortIndex = validWorkspaces.findIndex(
(content) => String(content.port) === portFromEnv,
(content) =>
content.port !== undefined && String(content.port) === portFromEnv,
);
if (matchingPortIndex !== -1) {
const selected = validWorkspaces[matchingPortIndex];
@@ -203,6 +203,7 @@ describe('MCPOAuthProvider', () => {
afterEach(() => {
vi.restoreAllMocks();
vi.unstubAllEnvs();
});
describe('authenticate', () => {
@@ -440,6 +441,100 @@ describe('MCPOAuthProvider', () => {
);
});
it('should perform dynamic client registration with Cloud Workstations proxy redirect URI when running in Google Cloud Workstations', async () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const configWithoutClient: MCPOAuthConfig = {
...mockConfig,
registrationUrl: 'https://auth.example.com/register',
};
delete configWithoutClient.clientId;
delete configWithoutClient.redirectUri;
const mockRegistrationResponse: OAuthClientRegistrationResponse = {
client_id: 'dynamic_client_id',
client_secret: 'dynamic_client_secret',
redirect_uris: [
'https://7777-my-workstation.cluster.workstations.cloud.google.com/oauth/callback',
],
grant_types: ['authorization_code', 'refresh_token'],
response_types: ['code'],
token_endpoint_auth_method: 'none',
};
mockFetch.mockResolvedValueOnce(
createMockResponse({
ok: true,
contentType: 'application/json',
text: JSON.stringify(mockRegistrationResponse),
json: mockRegistrationResponse,
}),
);
// Setup callback handler
let callbackHandler: unknown;
vi.mocked(http.createServer).mockImplementation((handler) => {
callbackHandler = handler;
return mockHttpServer as unknown as http.Server;
});
mockHttpServer.listen.mockImplementation((port, callback) => {
callback?.();
setTimeout(() => {
const mockReq = {
url: '/oauth/callback?code=auth_code_123&state=bW9ja19zdGF0ZV8xNl9ieXRlcw',
};
const mockRes = {
writeHead: vi.fn(),
end: vi.fn(),
};
(callbackHandler as (req: unknown, res: unknown) => void)(
mockReq,
mockRes,
);
}, 10);
});
// Mock token exchange
mockFetch.mockResolvedValueOnce(
createMockResponse({
ok: true,
contentType: 'application/json',
text: JSON.stringify(mockTokenResponse),
json: mockTokenResponse,
}),
);
const authProvider = new MCPOAuthProvider();
const result = await authProvider.authenticate(
'test-server',
configWithoutClient,
);
expect(result).toBeDefined();
expect(mockFetch).toHaveBeenCalledWith(
'https://auth.example.com/register',
expect.objectContaining({
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
client_name: 'Gemini CLI MCP Client',
redirect_uris: [
'https://7777-my-workstation.cluster.workstations.cloud.google.com/oauth/callback',
],
grant_types: ['authorization_code', 'refresh_token'],
response_types: ['code'],
token_endpoint_auth_method: 'none',
scope: 'read write',
}),
}),
);
});
it('should perform OAuth discovery and dynamic client registration when no client ID or registration URL provided', async () => {
const configWithoutClient: MCPOAuthConfig = { ...mockConfig };
delete configWithoutClient.clientId;
+2 -3
View File
@@ -21,7 +21,7 @@ import {
buildAuthorizationUrl,
exchangeCodeForToken,
refreshAccessToken as refreshAccessTokenShared,
REDIRECT_PATH,
getRedirectUri,
type OAuthFlowConfig,
type OAuthTokenResponse,
} from '../utils/oauth-flow.js';
@@ -99,8 +99,7 @@ export class MCPOAuthProvider {
config: MCPOAuthConfig,
redirectPort: number,
): Promise<OAuthClientRegistrationResponse> {
const redirectUri =
config.redirectUri || `http://localhost:${redirectPort}${REDIRECT_PATH}`;
const redirectUri = getRedirectUri(config, redirectPort);
const registrationRequest: OAuthClientRegistrationRequest = {
client_name: 'Gemini CLI MCP Client',
@@ -1,34 +1,53 @@
---
name: antigravity-support
description: Use when the user asks questions, seeks help, or requests instructions related to installing, setting up, or migrating to Antigravity CLI. This skill provides the latest up to date details, requirements, and commands sourced from the official Antigravity CLI documentation.
description:
Use when the user asks questions, seeks help, or requests instructions related
to installing, setting up, or migrating to Antigravity CLI. This skill
provides the latest up to date details, requirements, and commands sourced
from the official Antigravity CLI documentation.
---
# Antigravity CLI Support
This skill provides up-to-date information on how to install, configure, use, and migrate to Antigravity CLI, sourced from the official documentation at https://antigravity.google/docs/cli-getting-started.
This skill provides up-to-date information on how to install, configure, use,
and migrate to Antigravity CLI, sourced from the official documentation at
https://antigravity.google/docs/cli-getting-started.
## What is Antigravity CLI?
Antigravity CLI is a next-generation terminal interface for collaborating with autonomous agents on local codebases. It is designed to be highly interactive and agent-driven, launching a Terminal User Interface (TUI) to coordinate code generation, reasoning, and workspace tasks.
Antigravity CLI is a next-generation terminal interface for collaborating with
autonomous agents on local codebases. It is designed to be highly interactive
and agent-driven, launching a Terminal User Interface (TUI) to coordinate code
generation, reasoning, and workspace tasks.
Key Features:
- **Autonomous Agent Collaboration:** Work directly with agents within your terminal.
- **Interactive TUI:** A full terminal user interface designed for agent workflows.
- **Workspace Integration:** Deep understanding of your local workspace structure and context.
- **Autonomous Agent Collaboration:** Work directly with agents within your
terminal.
- **Interactive TUI:** A full terminal user interface designed for agent
workflows.
- **Workspace Integration:** Deep understanding of your local workspace
structure and context.
## Installation
To install the Antigravity CLI on your machine:
### macOS / Linux (Fast-Path Script)
Run the following standard curl command in your terminal:
```bash
curl -fsSL https://antigravity.google/cli/install.sh | bash
```
This script downloads, verifies, and installs the latest version of Antigravity, and automatically registers the `agy` binary in your PATH.
This script downloads, verifies, and installs the latest version of Antigravity,
and automatically registers the `agy` binary in your PATH.
### Windows (PowerShell)
For Windows environments, install via the official PowerShell setup command:
```powershell
irm https://antigravity.google/cli/install.ps1 | iex
```
@@ -36,23 +55,41 @@ irm https://antigravity.google/cli/install.ps1 | iex
## Initial Setup & Configuration
Once installed, navigate to any project or workspace directory and run:
```bash
agy
```
This command starts the Antigravity CLI. The first time you launch it, the interactive TUI will guide you through:
1. **Workspace Trust Verification:** Confirming trust for the workspace folder to allow secure local command execution and file edits.
2. **Visual Theme Configuration:** Setting up your preferred interactive terminal aesthetic and layout.
3. **Rendering Modes:** Tailoring TUI performance and drawing behaviors to your terminal capabilities.
This command starts the Antigravity CLI. The first time you launch it, the
interactive TUI will guide you through:
1. **Workspace Trust Verification:** Confirming trust for the workspace folder
to allow secure local command execution and file edits.
2. **Visual Theme Configuration:** Setting up your preferred interactive
terminal aesthetic and layout.
3. **Rendering Modes:** Tailoring TUI performance and drawing behaviors to your
terminal capabilities.
## How to Migrate to Antigravity CLI
If you are transitioning or migrating from another tool (such as Gemini CLI) to Antigravity CLI, follow these steps:
1. **Check Requirements:** Ensure your local environment meets standard requirements (e.g., node, git, shell access) and is running a compatible operating system (macOS, Linux, or Windows).
2. **Install Antigravity:** Run the installation script above to make the `agy` command globally available.
3. **Verify Installation:** Test the installation by running `agy --version` or launching `agy` in an empty or sample directory.
4. **Transition Workspaces:** Run `agy` directly inside your project workspace root. The initial setup assistant will guide you to import or configure trust policies, similar to those you might have used previously.
If you are transitioning or migrating from another tool (such as Gemini CLI) to
Antigravity CLI, follow these steps:
1. **Check Requirements:** Ensure your local environment meets standard
requirements (e.g., node, git, shell access) and is running a compatible
operating system (macOS, Linux, or Windows).
2. **Install Antigravity:** Run the installation script above to make the `agy`
command globally available.
3. **Verify Installation:** Test the installation by running `agy --version` or
launching `agy` in an empty or sample directory.
4. **Transition Workspaces:** Run `agy` directly inside your project workspace
root. The initial setup assistant will guide you to import or configure trust
policies, similar to those you might have used previously.
## Official Resources and Learning More
If you need more details or have advanced configuration/migration needs, please visit the official documentation:
- **Official Documentation:** https://antigravity.google/docs/cli-getting-started
If you need more details or have advanced configuration/migration needs, please
visit the official documentation:
- **Official Documentation:**
https://antigravity.google/docs/cli-getting-started
@@ -1,6 +1,9 @@
---
name: skill-creator
description: Guide for creating effective skills. This skill should be used when users want to create a new skill (or update an existing skill) that extends Gemini CLI's capabilities with specialized knowledge, workflows, or tool integrations.
description:
Guide for creating effective skills. This skill should be used when users want
to create a new skill (or update an existing skill) that extends Gemini CLI's
capabilities with specialized knowledge, workflows, or tool integrations.
---
# Skill Creator
@@ -9,22 +12,33 @@ This skill provides guidance for creating effective skills.
## About Skills
Skills are modular, self-contained packages that extend Gemini CLI's capabilities by providing specialized knowledge, workflows, and tools. Think of them as "onboarding guides" for specific domains or tasks—they transform Gemini CLI from a general-purpose agent into a specialized agent equipped with procedural knowledge that no model can fully possess.
Skills are modular, self-contained packages that extend Gemini CLI's
capabilities by providing specialized knowledge, workflows, and tools. Think of
them as "onboarding guides" for specific domains or tasks—they transform Gemini
CLI from a general-purpose agent into a specialized agent equipped with
procedural knowledge that no model can fully possess.
### What Skills Provide
1. Specialized workflows - Multi-step procedures for specific domains
2. Tool integrations - Instructions for working with specific file formats or APIs
2. Tool integrations - Instructions for working with specific file formats or
APIs
3. Domain expertise - Company-specific knowledge, schemas, business logic
4. Bundled resources - Scripts, references, and assets for complex and repetitive tasks
4. Bundled resources - Scripts, references, and assets for complex and
repetitive tasks
## Core Principles
### Concise is Key
The context window is a public good. Skills share the context window with everything else Gemini CLI needs: system prompt, conversation history, other Skills' metadata, and the actual user request.
The context window is a public good. Skills share the context window with
everything else Gemini CLI needs: system prompt, conversation history, other
Skills' metadata, and the actual user request.
**Default assumption: Gemini CLI is already very smart.** Only add context Gemini CLI doesn't already have. Challenge each piece of information: "Does Gemini CLI really need this explanation?" and "Does this paragraph justify its token cost?"
**Default assumption: Gemini CLI is already very smart.** Only add context
Gemini CLI doesn't already have. Challenge each piece of information: "Does
Gemini CLI really need this explanation?" and "Does this paragraph justify its
token cost?"
Prefer concise examples over verbose explanations.
@@ -32,13 +46,19 @@ Prefer concise examples over verbose explanations.
Match the level of specificity to the task's fragility and variability:
**High freedom (text-based instructions)**: Use when multiple approaches are valid, decisions depend on context, or heuristics guide the approach.
**High freedom (text-based instructions)**: Use when multiple approaches are
valid, decisions depend on context, or heuristics guide the approach.
**Medium freedom (pseudocode or scripts with parameters)**: Use when a preferred pattern exists, some variation is acceptable, or configuration affects behavior.
**Medium freedom (pseudocode or scripts with parameters)**: Use when a preferred
pattern exists, some variation is acceptable, or configuration affects behavior.
**Low freedom (specific scripts, few parameters)**: Use when operations are fragile and error-prone, consistency is critical, or a specific sequence must be followed.
**Low freedom (specific scripts, few parameters)**: Use when operations are
fragile and error-prone, consistency is critical, or a specific sequence must be
followed.
Think of Gemini CLI as exploring a path: a narrow bridge with cliffs needs specific guardrails (low freedom), while an open field allows many routes (high freedom).
Think of Gemini CLI as exploring a path: a narrow bridge with cliffs needs
specific guardrails (low freedom), while an open field allows many routes (high
freedom).
### Anatomy of a Skill
@@ -61,45 +81,75 @@ skill-name/
Every SKILL.md consists of:
- **Frontmatter** (YAML): Contains `name` and `description` fields. These are the only fields that Gemini CLI reads to determine when the skill gets used, thus it is very important to be clear and comprehensive in describing what the skill is, and when it should be used.
- **Body** (Markdown): Instructions and guidance for using the skill. Only loaded AFTER the skill triggers (if at all).
- **Frontmatter** (YAML): Contains `name` and `description` fields. These are
the only fields that Gemini CLI reads to determine when the skill gets used,
thus it is very important to be clear and comprehensive in describing what the
skill is, and when it should be used.
- **Body** (Markdown): Instructions and guidance for using the skill. Only
loaded AFTER the skill triggers (if at all).
#### Bundled Resources (optional)
##### Scripts (`scripts/`)
Executable code (Node.js/Python/Bash/etc.) for tasks that require deterministic reliability or are repeatedly rewritten.
Executable code (Node.js/Python/Bash/etc.) for tasks that require deterministic
reliability or are repeatedly rewritten.
- **When to include**: When the same code is being rewritten repeatedly or deterministic reliability is needed
- **When to include**: When the same code is being rewritten repeatedly or
deterministic reliability is needed
- **Example**: `scripts/rotate_pdf.cjs` for PDF rotation tasks
- **Benefits**: Token efficient, deterministic, may be executed without loading into context
- **Agentic Ergonomics**: Scripts must output LLM-friendly stdout. Suppress standard tracebacks. Output clear, concise success/failure messages, and paginate or truncate outputs (e.g., "Success: First 50 lines of processed file...") to prevent context window overflow.
- **Note**: Scripts may still need to be read by Gemini CLI for patching or environment-specific adjustments
- **Benefits**: Token efficient, deterministic, may be executed without loading
into context
- **Agentic Ergonomics**: Scripts must output LLM-friendly stdout. Suppress
standard tracebacks. Output clear, concise success/failure messages, and
paginate or truncate outputs (e.g., "Success: First 50 lines of processed
file...") to prevent context window overflow.
- **Note**: Scripts may still need to be read by Gemini CLI for patching or
environment-specific adjustments
##### References (`references/`)
Documentation and reference material intended to be loaded as needed into context to inform Gemini CLI's process and thinking.
Documentation and reference material intended to be loaded as needed into
context to inform Gemini CLI's process and thinking.
- **When to include**: For documentation that Gemini CLI should reference while working
- **Examples**: `references/finance.md` for financial schemas, `references/mnda.md` for company NDA template, `references/policies.md` for company policies, `references/api_docs.md` for API specifications
- **Use cases**: Database schemas, API documentation, domain knowledge, company policies, detailed workflow guides
- **Benefits**: Keeps SKILL.md lean, loaded only when Gemini CLI determines it's needed
- **Best practice**: If files are large (>10k words), include grep search patterns in SKILL.md
- **When to include**: For documentation that Gemini CLI should reference while
working
- **Examples**: `references/finance.md` for financial schemas,
`references/mnda.md` for company NDA template, `references/policies.md` for
company policies, `references/api_docs.md` for API specifications
- **Use cases**: Database schemas, API documentation, domain knowledge, company
policies, detailed workflow guides
- **Benefits**: Keeps SKILL.md lean, loaded only when Gemini CLI determines it's
needed
- **Best practice**: If files are large (>10k words), include grep search
patterns in SKILL.md
- **Avoid duplication**: Information should live in either SKILL.md or
references files, not both. Prefer references files for detailed information unless it's truly core to the skill—this keeps SKILL.md lean while making information discoverable without hogging the context window. Keep only essential procedural instructions and workflow guidance in SKILL.md; move detailed reference material, schemas, and examples to references files.
references files, not both. Prefer references files for detailed information
unless it's truly core to the skill—this keeps SKILL.md lean while making
information discoverable without hogging the context window. Keep only
essential procedural instructions and workflow guidance in SKILL.md; move
detailed reference material, schemas, and examples to references files.
##### Assets (`assets/`)
Files not intended to be loaded into context, but rather used within the output Gemini CLI produces.
Files not intended to be loaded into context, but rather used within the output
Gemini CLI produces.
- **When to include**: When the skill needs files that will be used in the final output
- **Examples**: `assets/logo.png` for brand assets, `assets/slides.pptx` for PowerPoint templates, `assets/frontend-template/` for HTML/React boilerplate, `assets/font.ttf` for typography
- **Use cases**: Templates, images, icons, boilerplate code, fonts, sample documents that get copied or modified
- **Benefits**: Separates output resources from documentation, enables Gemini CLI to use files without loading them into context
- **When to include**: When the skill needs files that will be used in the final
output
- **Examples**: `assets/logo.png` for brand assets, `assets/slides.pptx` for
PowerPoint templates, `assets/frontend-template/` for HTML/React boilerplate,
`assets/font.ttf` for typography
- **Use cases**: Templates, images, icons, boilerplate code, fonts, sample
documents that get copied or modified
- **Benefits**: Separates output resources from documentation, enables Gemini
CLI to use files without loading them into context
#### What to Not Include in a Skill
A skill should only contain essential files that directly support its functionality. Do NOT create extraneous documentation or auxiliary files, including:
A skill should only contain essential files that directly support its
functionality. Do NOT create extraneous documentation or auxiliary files,
including:
- README.md
- INSTALLATION_GUIDE.md
@@ -107,7 +157,10 @@ A skill should only contain essential files that directly support its functional
- CHANGELOG.md
- etc.
The skill should only contain the information needed for an AI agent to do the job at hand. It should not contain auxiliary context about the process that went into creating it, setup and testing procedures, user-facing documentation, etc. Creating additional documentation files just adds clutter and confusion.
The skill should only contain the information needed for an AI agent to do the
job at hand. It should not contain auxiliary context about the process that went
into creating it, setup and testing procedures, user-facing documentation, etc.
Creating additional documentation files just adds clutter and confusion.
### Progressive Disclosure Design Principle
@@ -115,13 +168,21 @@ Skills use a three-level loading system to manage context efficiently:
1. **Metadata (name + description)** - Always in context (~100 words)
2. **SKILL.md body** - When skill triggers (<5k words)
3. **Bundled resources** - As needed by Gemini CLI (Unlimited because scripts can be executed without reading into context window)
3. **Bundled resources** - As needed by Gemini CLI (Unlimited because scripts
can be executed without reading into context window)
#### Progressive Disclosure Patterns
Keep SKILL.md body to the essentials and under 500 lines to minimize context bloat. Split content into separate files when approaching this limit. When splitting out content into other files, it is very important to reference them from SKILL.md and describe clearly when to read them, to ensure the reader of the skill knows they exist and when to use them.
Keep SKILL.md body to the essentials and under 500 lines to minimize context
bloat. Split content into separate files when approaching this limit. When
splitting out content into other files, it is very important to reference them
from SKILL.md and describe clearly when to read them, to ensure the reader of
the skill knows they exist and when to use them.
**Key principle:** When a skill supports multiple variations, frameworks, or options, keep only the core workflow and selection guidance in SKILL.md. Move variant-specific details (patterns, examples, configuration) into separate reference files.
**Key principle:** When a skill supports multiple variations, frameworks, or
options, keep only the core workflow and selection guidance in SKILL.md. Move
variant-specific details (patterns, examples, configuration) into separate
reference files.
**Pattern 1: High-level guide with references**
@@ -143,7 +204,8 @@ Gemini CLI loads FORMS.md, REFERENCE.md, or EXAMPLES.md only when needed.
**Pattern 2: Domain-specific organization**
For Skills with multiple domains, organize content by domain to avoid loading irrelevant context:
For Skills with multiple domains, organize content by domain to avoid loading
irrelevant context:
```
bigquery-skill/
@@ -157,7 +219,8 @@ bigquery-skill/
When a user asks about sales metrics, Gemini CLI only reads sales.md.
Similarly, for skills supporting multiple frameworks or variants, organize by variant:
Similarly, for skills supporting multiple frameworks or variants, organize by
variant:
```
cloud-deploy/
@@ -183,15 +246,20 @@ Use pandas for loading and basic queries. See [PANDAS.md](PANDAS.md).
## Advanced Operations
For massive files that exceed memory, see [STREAMING.md](STREAMING.md). For timestamp normalization, see [TIMESTAMPS.md](TIMESTAMPS.md).
For massive files that exceed memory, see [STREAMING.md](STREAMING.md). For
timestamp normalization, see [TIMESTAMPS.md](TIMESTAMPS.md).
Gemini CLI reads REDLINING.md or OOXML.md only when the user needs those features.
Gemini CLI reads REDLINING.md or OOXML.md only when the user needs those
features.
```
**Important guidelines:**
- **Avoid deeply nested references** - Keep references one level deep from SKILL.md. All reference files should link directly from SKILL.md.
- **Structure longer reference files** - For files longer than 100 lines, include a table of contents at the top so Gemini CLI can see the full scope when previewing.
- **Avoid deeply nested references** - Keep references one level deep from
SKILL.md. All reference files should link directly from SKILL.md.
- **Structure longer reference files** - For files longer than 100 lines,
include a table of contents at the top so Gemini CLI can see the full scope
when previewing.
## Skill Creation Process
@@ -205,66 +273,93 @@ Skill creation involves these steps:
6. Install and reload the skill
7. Iterate based on real usage
Follow these steps in order, skipping only if there is a clear reason why they are not applicable.
Follow these steps in order, skipping only if there is a clear reason why they
are not applicable.
### Skill Naming
- Use lowercase letters, digits, and hyphens only; normalize user-provided titles to hyphen-case (e.g., "Plan Mode" -> `plan-mode`).
- When generating names, generate a name under 64 characters (letters, digits, hyphens).
- Use lowercase letters, digits, and hyphens only; normalize user-provided
titles to hyphen-case (e.g., "Plan Mode" -> `plan-mode`).
- When generating names, generate a name under 64 characters (letters, digits,
hyphens).
- Prefer short, verb-led phrases that describe the action.
- Namespace by tool when it improves clarity or triggering (e.g., `gh-address-comments`, `linear-address-issue`).
- Namespace by tool when it improves clarity or triggering (e.g.,
`gh-address-comments`, `linear-address-issue`).
- Name the skill folder exactly after the skill name.
### Step 1: Understanding the Skill with Concrete Examples
Skip this step only when the skill's usage patterns are already clearly understood. It remains valuable even when working with an existing skill.
Skip this step only when the skill's usage patterns are already clearly
understood. It remains valuable even when working with an existing skill.
To create an effective skill, clearly understand concrete examples of how the skill will be used. This understanding can come from either direct user examples or generated examples that are validated with user feedback.
To create an effective skill, clearly understand concrete examples of how the
skill will be used. This understanding can come from either direct user examples
or generated examples that are validated with user feedback.
For example, when building an image-editor skill, relevant questions include:
- "What functionality should the image-editor skill support? Editing, rotating, anything else?"
- "What functionality should the image-editor skill support? Editing, rotating,
anything else?"
- "Can you give some examples of how this skill would be used?"
- "I can imagine users asking for things like 'Remove the red-eye from this image' or 'Rotate this image'. Are there other ways you imagine this skill being used?"
- "I can imagine users asking for things like 'Remove the red-eye from this
image' or 'Rotate this image'. Are there other ways you imagine this skill
being used?"
- "What would a user say that should trigger this skill?"
**Avoid interrogation loops:** Do not ask more than one or two clarifying questions at a time. Bias toward action: propose a concrete list of features or examples based on your initial understanding, and ask the user to refine them.
**Avoid interrogation loops:** Do not ask more than one or two clarifying
questions at a time. Bias toward action: propose a concrete list of features or
examples based on your initial understanding, and ask the user to refine them.
Conclude this step when there is a clear sense of the functionality the skill should support.
Conclude this step when there is a clear sense of the functionality the skill
should support.
### Step 2: Planning the Reusable Skill Contents
To turn concrete examples into an effective skill, analyze each example by:
1. Considering how to execute on the example from scratch
2. Identifying what scripts, references, and assets would be helpful when executing these workflows repeatedly
2. Identifying what scripts, references, and assets would be helpful when
executing these workflows repeatedly
Example: When building a `pdf-editor` skill to handle queries like "Help me rotate this PDF," the analysis shows:
Example: When building a `pdf-editor` skill to handle queries like "Help me
rotate this PDF," the analysis shows:
1. Rotating a PDF requires re-writing the same code each time
2. A `scripts/rotate_pdf.cjs` script would be helpful to store in the skill
Example: When designing a `frontend-webapp-builder` skill for queries like "Build me a todo app" or "Build me a dashboard to track my steps," the analysis shows:
Example: When designing a `frontend-webapp-builder` skill for queries like
"Build me a todo app" or "Build me a dashboard to track my steps," the analysis
shows:
1. Writing a frontend webapp requires the same boilerplate HTML/React each time
2. An `assets/hello-world/` template containing the boilerplate HTML/React project files would be helpful to store in the skill
2. An `assets/hello-world/` template containing the boilerplate HTML/React
project files would be helpful to store in the skill
Example: When building a `big-query` skill to handle queries like "How many users have logged in today?" the analysis shows:
Example: When building a `big-query` skill to handle queries like "How many
users have logged in today?" the analysis shows:
1. Querying BigQuery requires re-discovering the table schemas and relationships each time
2. A `references/schema.md` file documenting the table schemas would be helpful to store in the skill
1. Querying BigQuery requires re-discovering the table schemas and relationships
each time
2. A `references/schema.md` file documenting the table schemas would be helpful
to store in the skill
To establish the skill's contents, analyze each concrete example to create a list of the reusable resources to include: scripts, references, and assets.
To establish the skill's contents, analyze each concrete example to create a
list of the reusable resources to include: scripts, references, and assets.
### Step 3: Initializing the Skill
At this point, it is time to actually create the skill.
Skip this step only if the skill being developed already exists, and iteration or packaging is needed. In this case, continue to the next step.
Skip this step only if the skill being developed already exists, and iteration
or packaging is needed. In this case, continue to the next step.
When creating a new skill from scratch, always run the `init_skill.cjs` script. The script conveniently generates a new template skill directory that automatically includes everything a skill requires, making the skill creation process much more efficient and reliable.
When creating a new skill from scratch, always run the `init_skill.cjs` script.
The script conveniently generates a new template skill directory that
automatically includes everything a skill requires, making the skill creation
process much more efficient and reliable.
**Note:** Use the absolute path to the script as provided in the `available_resources` section.
**Note:** Use the absolute path to the script as provided in the
`available_resources` section.
Usage:
@@ -277,30 +372,48 @@ The script:
- Creates the skill directory at the specified path
- Generates a SKILL.md template with proper frontmatter and TODO placeholders
- Creates example resource directories: `scripts/`, `references/`, and `assets/`
- Adds example files (`scripts/example_script.cjs`, `references/example_reference.md`, `assets/example_asset.txt`) that can be customized or deleted
- Adds example files (`scripts/example_script.cjs`,
`references/example_reference.md`, `assets/example_asset.txt`) that can be
customized or deleted
After initialization, customize or remove the generated SKILL.md and example files as needed.
After initialization, customize or remove the generated SKILL.md and example
files as needed.
### Step 4: Edit the Skill
When editing the (newly-generated or existing) skill, remember that the skill is being created for another instance of Gemini CLI to use. Include information that would be beneficial and non-obvious to Gemini CLI. Consider what procedural knowledge, domain-specific details, or reusable assets would help another Gemini CLI instance execute these tasks more effectively.
When editing the (newly-generated or existing) skill, remember that the skill is
being created for another instance of Gemini CLI to use. Include information
that would be beneficial and non-obvious to Gemini CLI. Consider what procedural
knowledge, domain-specific details, or reusable assets would help another Gemini
CLI instance execute these tasks more effectively.
#### Learn Proven Design Patterns
Consult these helpful guides based on your skill's needs:
- **Multi-step processes**: See references/workflows.md for sequential workflows and conditional logic
- **Specific output formats or quality standards**: See references/output-patterns.md for template and example patterns
- **Multi-step processes**: See references/workflows.md for sequential workflows
and conditional logic
- **Specific output formats or quality standards**: See
references/output-patterns.md for template and example patterns
These files contain established best practices for effective skill design.
#### Start with Reusable Skill Contents
To begin implementation, start with the reusable resources identified above: `scripts/`, `references/`, and `assets/` files. Note that this step may require user input. For example, when implementing a `brand-guidelines` skill, the user may need to provide brand assets or templates to store in `assets/`, or documentation to store in `references/`.
To begin implementation, start with the reusable resources identified above:
`scripts/`, `references/`, and `assets/` files. Note that this step may require
user input. For example, when implementing a `brand-guidelines` skill, the user
may need to provide brand assets or templates to store in `assets/`, or
documentation to store in `references/`.
Added scripts must be tested by actually running them to ensure there are no bugs and that the output matches what is expected. If there are many similar scripts, only a representative sample needs to be tested to ensure confidence that they all work while balancing time to completion.
Added scripts must be tested by actually running them to ensure there are no
bugs and that the output matches what is expected. If there are many similar
scripts, only a representative sample needs to be tested to ensure confidence
that they all work while balancing time to completion.
Any example files and directories not needed for the skill should be deleted. The initialization script creates example files in `scripts/`, `references/`, and `assets/` to demonstrate structure, but most skills won't need all of them.
Any example files and directories not needed for the skill should be deleted.
The initialization script creates example files in `scripts/`, `references/`,
and `assets/` to demonstrate structure, but most skills won't need all of them.
#### Update SKILL.md
@@ -311,11 +424,17 @@ Any example files and directories not needed for the skill should be deleted. Th
Write the YAML frontmatter with `name` and `description`:
- `name`: The skill name
- `description`: This is the primary triggering mechanism for your skill, and helps Gemini CLI understand when to use the skill.
- Include both what the Skill does and specific triggers/contexts for when to use it.
- **Must be a single-line string** (e.g., `description: Data ingestion...`). Quotes are optional.
- Include all "when to use" information here - Not in the body. The body is only loaded after triggering, so "When to Use This Skill" sections in the body are not helpful to Gemini CLI.
- Example: `description: Data ingestion, cleaning, and transformation for tabular data. Use when Gemini CLI needs to work with CSV/TSV files to analyze large datasets, normalize schemas, or merge sources.`
- `description`: This is the primary triggering mechanism for your skill, and
helps Gemini CLI understand when to use the skill.
- Include both what the Skill does and specific triggers/contexts for when to
use it.
- **Must be a single-line string** (e.g., `description: Data ingestion...`).
Quotes are optional.
- Include all "when to use" information here - Not in the body. The body is
only loaded after triggering, so "When to Use This Skill" sections in the
body are not helpful to Gemini CLI.
- Example:
`description: Data ingestion, cleaning, and transformation for tabular data. Use when Gemini CLI needs to work with CSV/TSV files to analyze large datasets, normalize schemas, or merge sources.`
Do not include any other fields in YAML frontmatter.
@@ -325,9 +444,13 @@ Write instructions for using the skill and its bundled resources.
### Step 5: Packaging a Skill
Once development of the skill is complete, it must be packaged into a distributable .skill file that gets shared with the user. The packaging process automatically validates the skill first (checking YAML and ensuring no TODOs remain) to ensure it meets all requirements:
Once development of the skill is complete, it must be packaged into a
distributable .skill file that gets shared with the user. The packaging process
automatically validates the skill first (checking YAML and ensuring no TODOs
remain) to ensure it meets all requirements:
**Note:** Use the absolute path to the script as provided in the `available_resources` section.
**Note:** Use the absolute path to the script as provided in the
`available_resources` section.
```bash
node <path-to-skill-creator>/scripts/package_skill.cjs <path/to/skill-folder>
@@ -342,20 +465,28 @@ node <path-to-skill-creator>/scripts/package_skill.cjs <path/to/skill-folder> ./
The packaging script will:
1. **Validate** the skill automatically, checking:
- YAML frontmatter format and required fields
- Skill naming conventions and directory structure
- Description completeness and quality
- File organization and resource references
2. **Package** the skill if validation passes, creating a .skill file named after the skill (e.g., `my-skill.skill`) that includes all files and maintains the proper directory structure for distribution. The .skill file is a zip file with a .skill extension.
2. **Package** the skill if validation passes, creating a .skill file named
after the skill (e.g., `my-skill.skill`) that includes all files and
maintains the proper directory structure for distribution. The .skill file is
a zip file with a .skill extension.
If validation fails, the script will report the errors and exit without creating a package. Fix any validation errors and run the packaging command again.
If validation fails, the script will report the errors and exit without creating
a package. Fix any validation errors and run the packaging command again.
### Step 6: Installing and Reloading a Skill
Once the skill is packaged into a `.skill` file, offer to install it for the user. Ask whether they would like to install it locally in the current folder (workspace scope) or at the user level (user scope).
Once the skill is packaged into a `.skill` file, offer to install it for the
user. Ask whether they would like to install it locally in the current folder
(workspace scope) or at the user level (user scope).
If the user agrees to an installation, perform it immediately using the `run_shell_command` tool:
If the user agrees to an installation, perform it immediately using the
`run_shell_command` tool:
- **Locally (workspace scope)**:
```bash
@@ -366,13 +497,19 @@ If the user agrees to an installation, perform it immediately using the `run_she
gemini skills install <path/to/skill-name.skill> --scope user
```
**Important:** After the installation is complete, notify the user that they MUST manually execute the `/skills reload` command in their interactive Gemini CLI session to enable the new skill. They can then verify the installation by running `/skills list`.
**Important:** After the installation is complete, notify the user that they
MUST manually execute the `/skills reload` command in their interactive Gemini
CLI session to enable the new skill. They can then verify the installation by
running `/skills list`.
Note: You (the agent) cannot execute the `/skills reload` command yourself; it must be done by the user in an interactive instance of Gemini CLI. Do not attempt to run it on their behalf.
Note: You (the agent) cannot execute the `/skills reload` command yourself; it
must be done by the user in an interactive instance of Gemini CLI. Do not
attempt to run it on their behalf.
### Step 7: Iterate
After testing the skill, users may request improvements. Often this happens right after using the skill, with fresh context of how the skill performed.
After testing the skill, users may request improvements. Often this happens
right after using the skill, with fresh context of how the skill performed.
**Iteration workflow:**
+143
View File
@@ -209,6 +209,126 @@ describe('oauth-flow', () => {
const parsed = new URL(url);
expect(parsed.searchParams.has('resource')).toBe(false);
});
it('should use the Cloud Workstations proxy callback URL when running inside Cloud Workstations', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const url = buildAuthorizationUrl(baseConfig, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe(
`https://3000-my-workstation.cluster.workstations.cloud.google.com${REDIRECT_PATH}`,
);
});
it('should convert explicitly configured localhost URL to Workstations proxy URL', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const config: OAuthFlowConfig = {
...baseConfig,
redirectUri: 'http://localhost:8080/custom/callback',
};
const url = buildAuthorizationUrl(config, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe(
'https://3000-my-workstation.cluster.workstations.cloud.google.com/custom/callback',
);
});
it('should convert explicitly configured 127.0.0.1 URL to Workstations proxy URL', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const config: OAuthFlowConfig = {
...baseConfig,
redirectUri: 'http://127.0.0.1:4000/oauth2callback',
};
const url = buildAuthorizationUrl(config, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe(
'https://3000-my-workstation.cluster.workstations.cloud.google.com/oauth2callback',
);
});
it('should convert explicitly configured [::1] IPv6 loopback URL to Workstations proxy URL', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const config: OAuthFlowConfig = {
...baseConfig,
redirectUri: 'http://[::1]:9090/oauth2callback',
};
const url = buildAuthorizationUrl(config, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe(
'https://3000-my-workstation.cluster.workstations.cloud.google.com/oauth2callback',
);
});
it('should preserve query parameters and hashes from the configured redirectUri', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const config: OAuthFlowConfig = {
...baseConfig,
redirectUri: 'http://localhost:5050/callback?tenant=123#token=abc',
};
const url = buildAuthorizationUrl(config, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe(
'https://3000-my-workstation.cluster.workstations.cloud.google.com/callback?tenant=123#token=abc',
);
});
it('should leave external explicitly configured redirect URIs untouched under Cloud Workstations', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const config: OAuthFlowConfig = {
...baseConfig,
redirectUri: 'https://external-domain.com/callback',
};
const url = buildAuthorizationUrl(config, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe(
'https://external-domain.com/callback',
);
});
it('should handle invalid redirect URIs gracefully by returning them as-is', () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
const config: OAuthFlowConfig = {
...baseConfig,
redirectUri: 'not-a-valid-url',
};
const url = buildAuthorizationUrl(config, basePkceParams, 3000);
const parsed = new URL(url);
expect(parsed.searchParams.get('redirect_uri')).toBe('not-a-valid-url');
});
});
describe('startCallbackServer', () => {
@@ -493,6 +613,29 @@ describe('oauth-flow', () => {
expect(body.get('redirect_uri')).toBe('https://custom.example.com/cb');
});
it('should use the Cloud Workstations proxy callback URL when running inside Cloud Workstations', async () => {
vi.stubEnv('GOOGLE_CLOUD_WORKSTATIONS', 'true');
vi.stubEnv(
'WEB_HOST',
'my-workstation.cluster.workstations.cloud.google.com',
);
mockFetch.mockResolvedValueOnce(
createMockResponse(
JSON.stringify({ access_token: 'tok', token_type: 'Bearer' }),
),
);
await exchangeCodeForToken(baseConfig, 'code', 'verifier', 3000);
const body = new URLSearchParams(
(mockFetch.mock.calls[0] as [string, RequestInit])[1].body as string,
);
expect(body.get('redirect_uri')).toBe(
`https://3000-my-workstation.cluster.workstations.cloud.google.com${REDIRECT_PATH}`,
);
});
it('should default token_type to Bearer when missing from JSON response', async () => {
mockFetch.mockResolvedValueOnce(
createMockResponse(JSON.stringify({ access_token: 'tok' })),
+42 -4
View File
@@ -70,6 +70,46 @@ export interface OAuthTokenResponse {
/** The path the local callback server listens on. */
export const REDIRECT_PATH = '/oauth/callback';
/**
* Helper to determine the redirect URI, taking Google Cloud Workstations proxy into account.
*/
export function getRedirectUri(
config: { redirectUri?: string },
redirectPort: number,
): string {
if (
process.env['GOOGLE_CLOUD_WORKSTATIONS'] === 'true' &&
process.env['WEB_HOST']
) {
if (config.redirectUri) {
try {
const parsed = new URL(config.redirectUri);
if (
parsed.hostname === 'localhost' ||
parsed.hostname === '127.0.0.1' ||
parsed.hostname === '[::1]'
) {
const port = String(redirectPort);
parsed.protocol = 'https:';
parsed.hostname = `${port}-${process.env['WEB_HOST']}`;
parsed.port = '';
return parsed.toString();
}
} catch {
// Fall back to returning config.redirectUri as-is if parsing fails
}
return config.redirectUri;
}
return `https://${redirectPort}-${process.env['WEB_HOST']}${REDIRECT_PATH}`;
}
if (config.redirectUri) {
return config.redirectUri;
}
return `http://localhost:${redirectPort}${REDIRECT_PATH}`;
}
const HTTP_OK = 200;
/**
@@ -291,8 +331,7 @@ export function buildAuthorizationUrl(
redirectPort: number,
resource?: string,
): string {
const redirectUri =
config.redirectUri || `http://localhost:${redirectPort}${REDIRECT_PATH}`;
const redirectUri = getRedirectUri(config, redirectPort);
const params = new URLSearchParams({
client_id: config.clientId,
@@ -446,8 +485,7 @@ export async function exchangeCodeForToken(
redirectPort: number,
resource?: string,
): Promise<OAuthTokenResponse> {
const redirectUri =
config.redirectUri || `http://localhost:${redirectPort}${REDIRECT_PATH}`;
const redirectUri = getRedirectUri(config, redirectPort);
const params = new URLSearchParams({
grant_type: 'authorization_code',
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli-devtools",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"license": "Apache-2.0",
"type": "module",
"main": "dist/src/index.js",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli-sdk",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"description": "Gemini CLI SDK",
"license": "Apache-2.0",
"repository": {
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@google/gemini-cli-test-utils",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"private": true,
"main": "src/index.ts",
"license": "Apache-2.0",
+1 -1
View File
@@ -2,7 +2,7 @@
"name": "gemini-cli-vscode-ide-companion",
"displayName": "Gemini CLI Companion",
"description": "Enable Gemini CLI with direct access to your IDE workspace.",
"version": "0.56.0-preview.1",
"version": "0.56.0-nightly.20260806.g761f604c1",
"publisher": "google",
"icon": "assets/icon.png",
"repository": {