chore: address PR feedback on type safety and path mappings

This commit is contained in:
Michael Bleigh
2026-04-12 19:16:18 -07:00
parent 9594a1822b
commit 94575adb42
2 changed files with 10 additions and 10 deletions
+9 -9
View File
@@ -231,11 +231,11 @@ describe('Task', () => {
mockEventBus,
);
const event = {
const event: ServerGeminiStreamEvent = {
type: GeminiEventType.Content,
value: 'test',
traceId: 'test-trace-id',
} as const;
};
await task.acceptAgentMessage(event);
@@ -268,10 +268,10 @@ describe('Task', () => {
);
const citationText = 'Source: example.com';
const citationEvent = {
const citationEvent: ServerGeminiStreamEvent = {
type: GeminiEventType.Citation,
value: citationText,
} as const;
};
await task.acceptAgentMessage(citationEvent);
@@ -311,10 +311,10 @@ describe('Task', () => {
mockEventBus,
);
const modelInfoEvent = {
const modelInfoEvent: ServerGeminiStreamEvent = {
type: GeminiEventType.ModelInfo,
value: 'new-model-name',
} as const;
};
await task.acceptAgentMessage(modelInfoEvent);
@@ -343,7 +343,7 @@ describe('Task', () => {
it.each([
{ eventType: GeminiEventType.Retry, eventName: 'Retry' },
{ eventType: GeminiEventType.InvalidStream, eventName: 'InvalidStream' },
])(
] as const)(
'should handle $eventName event without triggering error handling',
async ({ eventType }) => {
const mockConfig = createMockConfig();
@@ -367,9 +367,9 @@ describe('Task', () => {
const cancelPendingToolsSpy = vi.spyOn(task, 'cancelPendingTools');
const setTaskStateSpy = vi.spyOn(task, 'setTaskStateAndPublishUpdate');
const event = {
const event: ServerGeminiStreamEvent = {
type: eventType,
} as unknown as ServerGeminiStreamEvent;
};
await task.acceptAgentMessage(event);
+1 -1
View File
@@ -6,7 +6,7 @@
"composite": true,
"types": ["node", "vitest/globals"],
"paths": {
"*": ["./*"],
"src/*": ["./src/*"],
"@google/gemini-cli-core": ["./index.ts"]
}
},