remove approvalmodechanged event

This commit is contained in:
A.K.M. Adib
2026-03-11 11:47:41 -04:00
parent 45fc2065ca
commit bcfe615fed
3 changed files with 0 additions and 24 deletions

View File

@@ -197,7 +197,6 @@ const mockCoreEvents = vi.hoisted(() => ({
emitModelChanged: vi.fn(),
emitConsoleLog: vi.fn(),
emitQuotaChanged: vi.fn(),
emitApprovalModeChanged: vi.fn(),
on: vi.fn(),
}));

View File

@@ -2096,8 +2096,6 @@ export class Config implements McpContext, AgentLoopContext {
: 0;
}
coreEvents.emitApprovalModeChanged(mode);
const isPlanModeTransition =
currentMode !== mode &&
(currentMode === ApprovalMode.PLAN || mode === ApprovalMode.PLAN);

View File

@@ -9,7 +9,6 @@ import type { AgentDefinition } from '../agents/types.js';
import type { McpClient } from '../tools/mcp-client.js';
import type { ExtensionEvents } from './extensionLoader.js';
import type { EditorType } from './editor.js';
import type { ApprovalMode } from '../policy/types.js';
import type {
TokenStorageInitializationEvent,
KeychainAvailabilityEvent,
@@ -53,16 +52,6 @@ export interface ModelChangedPayload {
model: string;
}
/**
* Payload for the 'approval-mode-changed' event.
*/
export interface ApprovalModeChangedPayload {
/**
* The new approval mode that was set.
*/
mode: ApprovalMode;
}
/**
* Payload for the 'console-log' event.
*/
@@ -182,7 +171,6 @@ export interface QuotaChangedPayload {
export enum CoreEvent {
UserFeedback = 'user-feedback',
ModelChanged = 'model-changed',
ApprovalModeChanged = 'approval-mode-changed',
ConsoleLog = 'console-log',
Output = 'output',
MemoryChanged = 'memory-changed',
@@ -216,7 +204,6 @@ export interface EditorSelectedPayload {
export interface CoreEvents extends ExtensionEvents {
[CoreEvent.UserFeedback]: [UserFeedbackPayload];
[CoreEvent.ModelChanged]: [ModelChangedPayload];
[CoreEvent.ApprovalModeChanged]: [ApprovalModeChangedPayload];
[CoreEvent.ConsoleLog]: [ConsoleLogPayload];
[CoreEvent.Output]: [OutputPayload];
[CoreEvent.MemoryChanged]: [MemoryChangedPayload];
@@ -328,14 +315,6 @@ export class CoreEventEmitter extends EventEmitter<CoreEvents> {
this.emit(CoreEvent.ModelChanged, payload);
}
/**
* Notifies subscribers that the approval mode has changed.
*/
emitApprovalModeChanged(mode: ApprovalMode): void {
const payload: ApprovalModeChangedPayload = { mode };
this.emit(CoreEvent.ApprovalModeChanged, payload);
}
/**
* Notifies subscribers that settings have been modified.
*/