MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-24 04:52:43 -07:00
Code Issues Packages Projects Releases Wiki Activity

remove approvalmodechanged event

Browse Source
This commit is contained in:
A.K.M. Adib
2026-03-11 11:47:41 -04:00
parent 45fc2065ca
commit bcfe615fed
3 changed files with 0 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/core/src/config/config.test.ts
View File

@@ -197,7 +197,6 @@ const mockCoreEvents = vi.hoisted(() => ({
emitModelChanged: vi.fn(), emitModelChanged: vi.fn(),
emitConsoleLog: vi.fn(), emitConsoleLog: vi.fn(),
emitQuotaChanged: vi.fn(), emitQuotaChanged: vi.fn(),
emitApprovalModeChanged: vi.fn(),
on: vi.fn(), on: vi.fn(),
})); }));

2
packages/core/src/config/config.ts
View File

@@ -2096,8 +2096,6 @@ export class Config implements McpContext, AgentLoopContext {
: 0; : 0;
} }
coreEvents.emitApprovalModeChanged(mode);
const isPlanModeTransition = const isPlanModeTransition =
currentMode !== mode && currentMode !== mode &&
(currentMode === ApprovalMode.PLAN || mode === ApprovalMode.PLAN); (currentMode === ApprovalMode.PLAN || mode === ApprovalMode.PLAN);

21
packages/core/src/utils/events.ts
View File

@@ -9,7 +9,6 @@ import type { AgentDefinition } from '../agents/types.js';
import type { McpClient } from '../tools/mcp-client.js'; import type { McpClient } from '../tools/mcp-client.js';
import type { ExtensionEvents } from './extensionLoader.js'; import type { ExtensionEvents } from './extensionLoader.js';
import type { EditorType } from './editor.js'; import type { EditorType } from './editor.js';
import type { ApprovalMode } from '../policy/types.js';
import type { import type {
TokenStorageInitializationEvent, TokenStorageInitializationEvent,
KeychainAvailabilityEvent, KeychainAvailabilityEvent,
@@ -53,16 +52,6 @@ export interface ModelChangedPayload {
model: string; model: string;
} }
/**
* Payload for the 'approval-mode-changed' event.
*/
export interface ApprovalModeChangedPayload {
/**
* The new approval mode that was set.
*/
mode: ApprovalMode;
}
/** /**
* Payload for the 'console-log' event. * Payload for the 'console-log' event.
*/ */
@@ -182,7 +171,6 @@ export interface QuotaChangedPayload {
export enum CoreEvent { export enum CoreEvent {
UserFeedback = 'user-feedback', UserFeedback = 'user-feedback',
ModelChanged = 'model-changed', ModelChanged = 'model-changed',
ApprovalModeChanged = 'approval-mode-changed',
ConsoleLog = 'console-log', ConsoleLog = 'console-log',
Output = 'output', Output = 'output',
MemoryChanged = 'memory-changed', MemoryChanged = 'memory-changed',
@@ -216,7 +204,6 @@ export interface EditorSelectedPayload {
export interface CoreEvents extends ExtensionEvents { export interface CoreEvents extends ExtensionEvents {
[CoreEvent.UserFeedback]: [UserFeedbackPayload]; [CoreEvent.UserFeedback]: [UserFeedbackPayload];
[CoreEvent.ModelChanged]: [ModelChangedPayload]; [CoreEvent.ModelChanged]: [ModelChangedPayload];
[CoreEvent.ApprovalModeChanged]: [ApprovalModeChangedPayload];
[CoreEvent.ConsoleLog]: [ConsoleLogPayload]; [CoreEvent.ConsoleLog]: [ConsoleLogPayload];
[CoreEvent.Output]: [OutputPayload]; [CoreEvent.Output]: [OutputPayload];
[CoreEvent.MemoryChanged]: [MemoryChangedPayload]; [CoreEvent.MemoryChanged]: [MemoryChangedPayload];
@@ -328,14 +315,6 @@ export class CoreEventEmitter extends EventEmitter<CoreEvents> {
this.emit(CoreEvent.ModelChanged, payload); this.emit(CoreEvent.ModelChanged, payload);
} }
/**
* Notifies subscribers that the approval mode has changed.
*/
emitApprovalModeChanged(mode: ApprovalMode): void {
const payload: ApprovalModeChangedPayload = { mode };
this.emit(CoreEvent.ApprovalModeChanged, payload);
}
/** /**
* Notifies subscribers that settings have been modified. * Notifies subscribers that settings have been modified.
*/ */