45ecc6de1c
fix(hooks): force child_process PTY and fix settings structure in tests
2026-02-13 16:03:40 -08:00
f406576be8
fix(hooks): fix settings structure and use unique rig names for disabling tests
2026-02-13 16:03:40 -08:00
23590d2b42
fix(hooks): normalize disabled hook paths for Windows compatibility
2026-02-13 16:03:40 -08:00
0d2be9492e
fix(hooks): use file-based hooks instead of node -e for Windows reliability
2026-02-13 16:03:40 -08:00
8f108b039f
fix(hooks): increase timeout to 60s for Windows reliability
2026-02-13 16:03:40 -08:00
7fb17c883b
fix(hooks): final verified fixes for Windows flakiness
2026-02-13 16:03:39 -08:00
e6881afd32
repro: use single rig.setup and node -e for stability
2026-02-13 16:03:39 -08:00
458e41a79a
repro: use simple echo hook and re-enable rich logging
2026-02-13 16:03:39 -08:00
608364b207
repro: use node -e and shared setup to avoid EBUSY/PTY flakiness
2026-02-13 16:03:39 -08:00
bae538822a
repro: improve stability with node -e and flexible assertions
2026-02-13 16:03:39 -08:00
80e893b7ee
repro: use node -e for failing tests and fix setup order
2026-02-13 16:03:39 -08:00
dcb35b2d07
repro: use echo instead of node for failing tests and focus them
2026-02-13 16:03:39 -08:00
780a8315ca
fix(hooks): correctly order rig.setup in system tests
2026-02-13 16:03:39 -08:00
cef4dbe76a
fix(hooks): final verified fixes for Windows flakiness (fully clean)
2026-02-13 16:03:39 -08:00
fe07abe851
repro: trigger run again
2026-02-13 16:03:39 -08:00
b6bfdfa907
repro: use rig.createScript and telemetry for failing tests
2026-02-13 16:03:39 -08:00
6ec2ebcf5a
repro: use unique strings for disabling tests and focus them
2026-02-13 16:03:39 -08:00
de151a4e21
repro: use rig.createScript for disabling tests and focus them
2026-02-13 16:03:39 -08:00
90f3f672ca
fix(hooks): final verified fixes for Windows flakiness
2026-02-13 16:03:39 -08:00
2c300fb378
repro: improve telemetry assertion to check stdout/stderr
2026-02-13 16:03:39 -08:00
5b371082e3
repro: always parse JSON from hook output regardless of exit code
2026-02-13 16:03:18 -08:00
5369d6509b
repro: use simple node script for block test
2026-02-13 16:03:11 -08:00
6655b0afd4
repro: use simple echo hook and re-enable rich logging
2026-02-13 16:03:11 -08:00
efab27e67b
repro: final clean verified fixes for Windows flakiness
2026-02-13 16:03:11 -08:00
cbba40eb66
repro: re-enable diagnostic logging and focus failing hook tests
2026-02-13 16:03:11 -08:00
80a0f04cfd
fix(hooks): resolve Windows flakiness and improve reliability
2026-02-13 16:03:10 -08:00
b077cfe061
repro: normalize hook names and use JSON for blocking test
2026-02-13 16:03:10 -08:00
b180351542
fix(hooks): treat all non-zero exit codes except 1 as blocking
2026-02-13 16:03:10 -08:00
edba8ddfc0
repro: test with exit code 101
2026-02-13 16:03:10 -08:00
9b4e3e7c53
repro: add even more logging to HookRunner and TestRig
2026-02-13 16:03:10 -08:00
0017a72273
repro: rich logging and focused tests
2026-02-13 16:03:10 -08:00
cb12e2f592
repro: allow vitest .only and focus on stderr blocking test
2026-02-13 16:03:10 -08:00
4946a5be73
repro: retry rmdir, add more logging, and focus on failing tests
2026-02-13 16:03:09 -08:00
f54fe58d06
test: fix windows environment and cleanup issues
...
- Ensure 'SystemRoot', 'COMSPEC', 'windir', and 'PATHEXT' are passed to node-pty on Windows to prevent 'posix_spawnp' failures.
- Clean up test directories in 'TestRig.setup' to ensure a fresh state for retries and prevent telemetry log accumulation (fixing the 1, 2, 3 failure pattern).
- Fix path normalization in 'Hook Disabling' test to ensure disabled hooks are correctly matched on Windows.
Part of https://github.com/google-gemini/gemini-cli/pull/18665
2026-02-13 16:03:09 -08:00
bd7904a9f7
test: robust fixes for windows hook flakiness
...
- Enforce 'sequential: true' for all hook tests to prevent telemetry leaks and race conditions.
- Normalize all path assertions in hooks-system.test.ts using a new 'normalizePath' helper to handle Windows backslashes consistently.
- Update 'createScript' in test-rig to return normalized paths.
- Ensure 'PATH' is explicitly passed to node-pty spawn options to prevent 'posix_spawnp' errors in some environments.
- Clean up manual path replacements in tests in favor of the centralized helper.
Part of https://github.com/google-gemini/gemini-cli/pull/18665
2026-02-13 16:03:09 -08:00
519bf324b0
test: standardize hook system tests for windows compatibility
...
- Refactored remaining hook tests in hooks-system.test.ts to use 'rig.createScript' and forward slashes for cross-platform path compatibility.
- Replaced 'node -e' usages with script files to avoid brittle quoting and escaping issues on Windows shells.
Part of https://github.com/google-gemini/gemini-cli/pull/18665
2026-02-13 16:03:09 -08:00
9631dc8abf
test: fix hook integration test flakiness on Windows CI
...
- Increase default timeout for TestRig.run and TestRig.runCommand to 10 minutes on Windows CI to handle slow environments.
- Replace inline 'node -e' hook commands with script files to avoid brittle quoting and escaping issues on Windows shells.
- Add 'TestRig.createScript' helper to simplify script creation in tests.
- Fix path escaping for hook output files in 'hooks-agent-flow.test.ts' using JSON.stringify.
- Ensure 'TestRig.setup' is called before performing file operations in tests.
2026-02-13 16:03:08 -08:00
0a77999d73
test(core): mock fetch in OAuth transport fallback tests ( #17059 )
...
Co-authored-by: Bryan Morgan <bryanmorgan@google.com >
2026-01-28 13:30:08 +00:00
c21c297133
feat(plan): refactor TestRig and eval helper to support configurable approval modes ( #17171 )
2026-01-21 15:43:48 +00:00
211d2c5fdd
feat(core): Ensure all properties in hooks object are event names. ( #16870 )
2026-01-20 22:47:31 +00:00
88df6210eb
Test coverage for hook exit code cases ( #17041 )
2026-01-20 17:13:15 +00:00
56092bd782
feat(hooks): Add a hooks.enabled setting. ( #15933 )
2026-01-06 21:33:37 +00:00
8f0324d868
fix(cli): resolve paste issue on Windows terminals. ( #15932 )
2026-01-05 22:46:23 +00:00
6d1e27633a
Support context injection via SessionStart hook. ( #15746 )
2026-01-05 21:27:53 +00:00
05049b5abf
feat(hooks): implement STOP_EXECUTION and enhance hook decision handling ( #15685 )
2025-12-30 23:22:53 +00:00
90eb1e0281
Implement support for tool input modification ( #15492 )
2025-12-30 19:37:43 +00:00
15c9f88da6
fix(hooks): deduplicate agent hooks and add cross-platform integration tests ( #15701 )
2025-12-30 19:13:16 +00:00
bb0c0d8ee3
Simplify method signature. ( #15114 )
2025-12-15 21:18:04 +00:00
b8c038f41f
feat(hooks): Hooks Commands Panel, Enable/Disable, and Migrate ( #14225 )
2025-12-03 18:01:57 +00:00
1c12da1fad
feat(hooks): Hook Session Lifecycle & Compression Integration ( #14151 )
2025-12-03 17:04:13 +00:00
Taylor Mullen