Commit Graph

4691 Commits

Author SHA1 Message Date
Taylor Mullen 0d2be9492e fix(hooks): use file-based hooks instead of node -e for Windows reliability 2026-02-13 16:03:40 -08:00
Taylor Mullen 8f108b039f fix(hooks): increase timeout to 60s for Windows reliability 2026-02-13 16:03:40 -08:00
Taylor Mullen 7fb17c883b fix(hooks): final verified fixes for Windows flakiness 2026-02-13 16:03:39 -08:00
Taylor Mullen e6881afd32 repro: use single rig.setup and node -e for stability 2026-02-13 16:03:39 -08:00
Taylor Mullen 458e41a79a repro: use simple echo hook and re-enable rich logging 2026-02-13 16:03:39 -08:00
Taylor Mullen 608364b207 repro: use node -e and shared setup to avoid EBUSY/PTY flakiness 2026-02-13 16:03:39 -08:00
Taylor Mullen bae538822a repro: improve stability with node -e and flexible assertions 2026-02-13 16:03:39 -08:00
Taylor Mullen 80e893b7ee repro: use node -e for failing tests and fix setup order 2026-02-13 16:03:39 -08:00
Taylor Mullen dcb35b2d07 repro: use echo instead of node for failing tests and focus them 2026-02-13 16:03:39 -08:00
Taylor Mullen 780a8315ca fix(hooks): correctly order rig.setup in system tests 2026-02-13 16:03:39 -08:00
Taylor Mullen cef4dbe76a fix(hooks): final verified fixes for Windows flakiness (fully clean) 2026-02-13 16:03:39 -08:00
Taylor Mullen fe07abe851 repro: trigger run again 2026-02-13 16:03:39 -08:00
Taylor Mullen b6bfdfa907 repro: use rig.createScript and telemetry for failing tests 2026-02-13 16:03:39 -08:00
Taylor Mullen 6ec2ebcf5a repro: use unique strings for disabling tests and focus them 2026-02-13 16:03:39 -08:00
Taylor Mullen de151a4e21 repro: use rig.createScript for disabling tests and focus them 2026-02-13 16:03:39 -08:00
Taylor Mullen 90f3f672ca fix(hooks): final verified fixes for Windows flakiness 2026-02-13 16:03:39 -08:00
Taylor Mullen 2c300fb378 repro: improve telemetry assertion to check stdout/stderr 2026-02-13 16:03:39 -08:00
Taylor Mullen 5b371082e3 repro: always parse JSON from hook output regardless of exit code 2026-02-13 16:03:18 -08:00
Taylor Mullen 5369d6509b repro: use simple node script for block test 2026-02-13 16:03:11 -08:00
Taylor Mullen 6655b0afd4 repro: use simple echo hook and re-enable rich logging 2026-02-13 16:03:11 -08:00
Taylor Mullen 1780234b13 repro: restore writeFileSync and fix hook blocking test 2026-02-13 16:03:11 -08:00
Taylor Mullen efab27e67b repro: final clean verified fixes for Windows flakiness 2026-02-13 16:03:11 -08:00
Taylor Mullen 009cdd92ba repro: fix syntax error and allow focused tests 2026-02-13 16:03:11 -08:00
Taylor Mullen cbba40eb66 repro: re-enable diagnostic logging and focus failing hook tests 2026-02-13 16:03:11 -08:00
Taylor Mullen 88d677207c fix(hooks): final verified fixes for Windows flakiness (clean version) 2026-02-13 16:03:11 -08:00
Taylor Mullen a68d08d5b5 fix(hooks): truly final verified fixes for Windows flakiness 2026-02-13 16:03:10 -08:00
Taylor Mullen 80db53e993 fix(hooks): final verified fixes for Windows flakiness 2026-02-13 16:03:10 -08:00
Taylor Mullen 80a0f04cfd fix(hooks): resolve Windows flakiness and improve reliability 2026-02-13 16:03:10 -08:00
Taylor Mullen b077cfe061 repro: normalize hook names and use JSON for blocking test 2026-02-13 16:03:10 -08:00
Taylor Mullen 20bcd4e2a2 repro: fix unused variable build error 2026-02-13 16:03:10 -08:00
Taylor Mullen b180351542 fix(hooks): treat all non-zero exit codes except 1 as blocking 2026-02-13 16:03:10 -08:00
Taylor Mullen edba8ddfc0 repro: test with exit code 101 2026-02-13 16:03:10 -08:00
Taylor Mullen 9b4e3e7c53 repro: add even more logging to HookRunner and TestRig 2026-02-13 16:03:10 -08:00
Taylor Mullen 0c04bc4cf6 repro: add logging to PolicyEngine and HookRunner conversion 2026-02-13 16:03:10 -08:00
Taylor Mullen 06f9479ac2 repro: add more logging to HookRegistry and CoreToolScheduler 2026-02-13 16:03:10 -08:00
Taylor Mullen 0017a72273 repro: rich logging and focused tests 2026-02-13 16:03:10 -08:00
Taylor Mullen cb12e2f592 repro: allow vitest .only and focus on stderr blocking test 2026-02-13 16:03:10 -08:00
Taylor Mullen 4946a5be73 repro: retry rmdir, add more logging, and focus on failing tests 2026-02-13 16:03:09 -08:00
Taylor Mullen a3b4a0a677 repro: enable push trigger for debugging 2026-02-13 16:03:09 -08:00
Taylor Mullen dca9c9ed36 fix(test-rig): only clean test directories on first setup call for a rig instance 2026-02-13 16:03:09 -08:00
Taylor Mullen d89916c195 repro: truly disable other jobs and fix TS error 2026-02-13 16:03:09 -08:00
Taylor Mullen b75b8b9b75 repro: add diagnostic logging for setup, cleanup, and pty spawn 2026-02-13 16:03:09 -08:00
Taylor Mullen afe0ad7088 repro: fast windows hook debugging workflow 2026-02-13 16:03:09 -08:00
Taylor Mullen f54fe58d06 test: fix windows environment and cleanup issues
- Ensure 'SystemRoot', 'COMSPEC', 'windir', and 'PATHEXT' are passed to node-pty on Windows to prevent 'posix_spawnp' failures.
- Clean up test directories in 'TestRig.setup' to ensure a fresh state for retries and prevent telemetry log accumulation (fixing the 1, 2, 3 failure pattern).
- Fix path normalization in 'Hook Disabling' test to ensure disabled hooks are correctly matched on Windows.

Part of https://github.com/google-gemini/gemini-cli/pull/18665
2026-02-13 16:03:09 -08:00
Taylor Mullen 3643c882ee repro: run only hooks-system.test.ts on windows 2026-02-13 16:03:09 -08:00
Taylor Mullen bd7904a9f7 test: robust fixes for windows hook flakiness
- Enforce 'sequential: true' for all hook tests to prevent telemetry leaks and race conditions.
- Normalize all path assertions in hooks-system.test.ts using a new 'normalizePath' helper to handle Windows backslashes consistently.
- Update 'createScript' in test-rig to return normalized paths.
- Ensure 'PATH' is explicitly passed to node-pty spawn options to prevent 'posix_spawnp' errors in some environments.
- Clean up manual path replacements in tests in favor of the centralized helper.

Part of https://github.com/google-gemini/gemini-cli/pull/18665
2026-02-13 16:03:09 -08:00
Taylor Mullen 519bf324b0 test: standardize hook system tests for windows compatibility
- Refactored remaining hook tests in hooks-system.test.ts to use 'rig.createScript' and forward slashes for cross-platform path compatibility.
- Replaced 'node -e' usages with script files to avoid brittle quoting and escaping issues on Windows shells.

Part of https://github.com/google-gemini/gemini-cli/pull/18665
2026-02-13 16:03:09 -08:00
Taylor Mullen 9631dc8abf test: fix hook integration test flakiness on Windows CI
- Increase default timeout for TestRig.run and TestRig.runCommand to 10 minutes on Windows CI to handle slow environments.
- Replace inline 'node -e' hook commands with script files to avoid brittle quoting and escaping issues on Windows shells.
- Add 'TestRig.createScript' helper to simplify script creation in tests.
- Fix path escaping for hook output files in 'hooks-agent-flow.test.ts' using JSON.stringify.
- Ensure 'TestRig.setup' is called before performing file operations in tests.
2026-02-13 16:03:08 -08:00
Tommaso Sciortino 02da5ebbc1 chore: fix dep vulnerabilities (#19036) 2026-02-13 23:45:33 +00:00
Jacob Richman 401bef1d2b bug(ui) fix flicker refreshing background color (#19041) 2026-02-13 23:33:02 +00:00